-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMSBIOHUB-223: Observations Prototype #1097
Conversation
Openshift URLs for the PR Deployment: |
Codecov Report
@@ Coverage Diff @@
## dev #1097 +/- ##
==========================================
- Coverage 63.71% 63.50% -0.21%
==========================================
Files 530 533 +3
Lines 15641 15817 +176
Branches 2465 2472 +7
==========================================
+ Hits 9965 10044 +79
- Misses 4990 5087 +97
Partials 686 686
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Update observation delete function to handle empty array of observation ids.
…to observations-prototype
api/src/paths/project/{projectId}/survey/{surveyId}/observation/index.ts
Outdated
Show resolved
Hide resolved
database/src/migrations/20230925103600_create_survey_observations.ts
Outdated
Show resolved
Hide resolved
…to observations-prototype
…to observations-prototype
…to numeric(10, 7)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ran this locally and the add/ edit and delete all work as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌞
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Links to Jira Tickets
Description of Changes
Testing Notes
TBD.