Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-223: Observations Prototype #1097

Merged
merged 75 commits into from
Sep 29, 2023
Merged

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Sep 19, 2023

Links to Jira Tickets

Description of Changes

  • Adds migration to create the survey observations table
  • Adds a DataGrid component for creating, editing and deleting observation records
  • Adds the Observation Context for maintaining survey observations
  • Adds an endpoint and service and repo methods for update/inserting and retrieving survey observation records

Testing Notes

Note: Requires make clean web

TBD.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #1097 (c093844) into dev (1673dec) will decrease coverage by 0.21%.
The diff coverage is 42.59%.

@@            Coverage Diff             @@
##              dev    #1097      +/-   ##
==========================================
- Coverage   63.71%   63.50%   -0.21%     
==========================================
  Files         530      533       +3     
  Lines       15641    15817     +176     
  Branches     2465     2472       +7     
==========================================
+ Hits         9965    10044      +79     
- Misses       4990     5087      +97     
  Partials      686      686              
Files Coverage Δ
api/src/repositories/observation-repository.ts 100.00% <100.00%> (ø)
api/src/services/observation-service.ts 100.00% <100.00%> (ø)
app/src/features/projects/ProjectsRouter.tsx 0.00% <ø> (ø)
...src/features/projects/create/CreateProjectPage.tsx 72.72% <100.00%> (+0.27%) ⬆️
...pp/src/features/projects/list/ProjectsListPage.tsx 79.16% <100.00%> (+0.90%) ⬆️
...res/surveys/observations/SurveyObservationPage.tsx 0.00% <ø> (ø)
app/src/hooks/useDataLoader.ts 81.81% <100.00%> (ø)
app/src/components/map/WFSFeatureGroup.tsx 4.44% <0.00%> (ø)
...s/surveys/observations/SurveyObservationHeader.tsx 0.00% <0.00%> (ø)
...s/observations/sampling-sites/SamplingSiteList.tsx 0.00% <0.00%> (ø)
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@curtisupshall curtisupshall changed the title Observations Prototype SIMSBIOHUB-223: Observations Prototype Sep 25, 2023
al-rosenthal
al-rosenthal previously approved these changes Sep 29, 2023
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran this locally and the add/ edit and delete all work as expected

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌞

@NickPhura NickPhura removed the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Sep 29, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

@curtisupshall curtisupshall merged commit df69dcb into dev Sep 29, 2023
@curtisupshall curtisupshall deleted the observations-prototype branch September 29, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants