Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB 281 - Update Animal Form and Table #1098

Merged
merged 254 commits into from
Sep 21, 2023
Merged

Conversation

GrahamS-Quartech
Copy link
Contributor

Links to Jira Tickets

Description of Changes

  • Removed Critter ID (to be included in edit view later) from Animals table and added WLH ID.
  • Added WLH ID to animal submission form.
  • Animal ID will now display as Alias
  • Separated device list into current devices and previous devices (this is based off deployment timestamps)
  • Added collection unit sub section (displays as Ecological Units) to animal submission form. Will correctly disallow duplicates of categories on the same animal.

MacQSL and others added 30 commits July 18, 2023 11:59
…o critterbase calls, still need to implement automated signup
…mponents can now be added to form on button click
… calling cb api through hooks in the frontend. No more extra auth headers, now all done through keycloak JWT.
…rbase. Made a wrapper function for critterbase selects that uses existing Formik components
…der and the docker compose that we don't need anymore
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #1098 (214a0ef) into dev (c62c52b) will increase coverage by 0.14%.
The diff coverage is 74.28%.

@@            Coverage Diff             @@
##              dev    #1098      +/-   ##
==========================================
+ Coverage   64.74%   64.89%   +0.14%     
==========================================
  Files         491      492       +1     
  Lines       14658    14688      +30     
  Branches     2295     2300       +5     
==========================================
+ Hits         9491     9532      +41     
+ Misses       4559     4529      -30     
- Partials      608      627      +19     
Files Changed Coverage Δ
app/src/features/surveys/view/SurveyAnimals.tsx 44.94% <ø> (ø)
...rveys/view/survey-animals/IndividualAnimalForm.tsx 20.00% <ø> (ø)
...survey-animals/form-sections/GeneralAnimalForm.tsx 16.66% <0.00%> (ø)
app/src/hooks/api/useSurveyApi.ts 42.85% <ø> (ø)
...surveys/view/survey-animals/SurveyAnimalsTable.tsx 73.68% <44.44%> (-26.32%) ⬇️
...animals/form-sections/CollectionUnitAnimalForm.tsx 83.33% <83.33%> (ø)
app/src/components/fields/CbSelectField.tsx 41.93% <100.00%> (+38.60%) ⬆️
...src/features/surveys/view/survey-animals/animal.ts 71.55% <100.00%> (+3.29%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

app/src/constants/i18n.ts Outdated Show resolved Hide resolved
app/src/constants/i18n.ts Outdated Show resolved Hide resolved
app/src/features/surveys/view/survey-animals/animal.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@JeremyQuartech JeremyQuartech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions, seems to be working well 👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GrahamS-Quartech GrahamS-Quartech merged commit 18aae70 into dev Sep 21, 2023
@NickPhura NickPhura deleted the SIMSBIOHUB-281 branch October 13, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants