Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Header and Footer Updates #1099

Merged
merged 6 commits into from
Sep 25, 2023
Merged

Application Header and Footer Updates #1099

merged 6 commits into from
Sep 25, 2023

Conversation

jeznorth
Copy link
Contributor

Links to Jira Tickets

  • Support updated layout of application required in SIMSBIOHUB-219

Description of Changes

  • Implemented full-width header and footer components
  • Collapsed the navbar into a single contained element
  • Added responsive menu to support smaller viewports
  • Removed global styling from externally referenced stylesheet to application theme file.

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #1099 (2cb7560) into dev (42d9bdb) will decrease coverage by 0.02%.
The diff coverage is 63.15%.

@@            Coverage Diff             @@
##              dev    #1099      +/-   ##
==========================================
- Coverage   65.42%   65.40%   -0.02%     
==========================================
  Files         492      492              
  Lines       14688    14697       +9     
  Branches     2300     2302       +2     
==========================================
+ Hits         9609     9613       +4     
- Misses       4445     4448       +3     
- Partials      634      636       +2     
Files Changed Coverage Δ
app/src/components/layout/Footer.tsx 100.00% <ø> (ø)
app/src/components/layout/Header.tsx 68.96% <63.15%> (-11.04%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@curtisupshall curtisupshall self-assigned this Sep 20, 2023
curtisupshall
curtisupshall previously approved these changes Sep 20, 2023
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test manually. New header is looking great! 💅

al-rosenthal
al-rosenthal previously approved these changes Sep 21, 2023
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏞️

curtisupshall
curtisupshall previously approved these changes Sep 21, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@NickPhura
Copy link
Collaborator

NickPhura commented Sep 21, 2023

@jeznorth
Minor: Shouldn't the "Support" header item always be at the far right of the list of menu items (and just before the "Log Out" option in the collapsed menu)? Currently, for non-admins it is. But for admin users its between "Projects" and "Manage Users", which feels a bit funny.

Discussed: will address separately afterwards

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖

@al-rosenthal al-rosenthal merged commit 79ef00f into dev Sep 25, 2023
@al-rosenthal al-rosenthal deleted the app-header-updates branch September 25, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants