Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB 217 - Edit Animal #1101

Merged
merged 280 commits into from
Sep 29, 2023
Merged

SIMSBIOHUB 217 - Edit Animal #1101

merged 280 commits into from
Sep 29, 2023

Conversation

GrahamS-Quartech
Copy link
Contributor

@GrahamS-Quartech GrahamS-Quartech commented Sep 25, 2023

Links to Jira Tickets

SIMSBIOHUB-217

Description of Changes

  • The button for Edit Animal has been restored in the three dots action menu within rows of the survey animal table.
  • Selecting this button will bring up an edit version of the animal form. All previously recorded values should be auto filled.
  • You can edit existing records, add new records, and delete records all from the same form.
  • Critter ID has been moved out of the animal table to instead be displayed at the top of this form.

Testing Notes

  • A patch to Critterbase is required to support some of the new delete / update operations, will edit this comment once it's in.

MacQSL and others added 30 commits July 26, 2023 12:13
…adds a ClickMarker component that can be placed on map with mouse click. Resizable circle zone requires some work.
…component to reflect this. Circle resize function now occurs on click and hold, so you can still replace the marker if you click inside the circle.
…o fixed CbSelect to use a normal select instead of subtext select
…They sync with each other and both work with the map
…ct so that you can do actions based off the label (which often differs from the real value). MarkerWithResizableRadius has a red option now.
…forms so that it can be reused across components.
api/src/openapi/schemas/critter.ts Outdated Show resolved Hide resolved
api/src/openapi/schemas/critter.ts Outdated Show resolved Hide resolved
curtisupshall
curtisupshall previously approved these changes Sep 28, 2023
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great!

JeremyQuartech
JeremyQuartech previously approved these changes Sep 28, 2023
Copy link
Contributor

@JeremyQuartech JeremyQuartech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@JeremyQuartech JeremyQuartech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@GrahamS-Quartech GrahamS-Quartech merged commit 1673dec into dev Sep 29, 2023
@GrahamS-Quartech GrahamS-Quartech deleted the SIMSBIOHUB-217 branch September 29, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants