-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMSBIOHUB 217 - Edit Animal #1101
Conversation
…ile, updated refs
…rking form validation
…adds a ClickMarker component that can be placed on map with mouse click. Resizable circle zone requires some work.
…component to reflect this. Circle resize function now occurs on click and hold, so you can still replace the marker if you click inside the circle.
…o fixed CbSelect to use a normal select instead of subtext select
… into BCTW-935-Add-Critter-Form
…They sync with each other and both work with the map
… into BCTW-935-Add-Critter-Form
…ell as UTM coordinate convversion
…biohubbc into BCTW-935-Add-Critter-Form
…tion that uses the critter by id endpoint
… into BCTW-935-Add-Critter-Form
…ct so that you can do actions based off the label (which often differs from the real value). MarkerWithResizableRadius has a red option now.
…forms so that it can be reused across components.
…g input, refactored CbSelectField a bit
…ething in CbSelectField. Also updated openapi bulk objects with more fleshed out structure
…arious survey critter routes, handles errors in auto filling the edit animal form more gracefully
api/src/paths/project/{projectId}/survey/{surveyId}/critters/{critterId}.ts
Outdated
Show resolved
Hide resolved
…, throw correct status code instead of generic error
…ly after updates. Added remove critter dialog component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
abdab7a
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Links to Jira Tickets
SIMSBIOHUB-217
Description of Changes
Testing Notes
A patch to Critterbase is required to support some of the new delete / update operations, will edit this comment once it's in.