Telemetry UI Updates #1105

JeremyQuartech · 2023-10-03T18:41:00Z

Description of Changes

Updated styling of Add telemetry device dialog
Changed edit telemetry details to render each device as a card
Minor changes to Individual animals nomenclature
Styling improvements on individual animals table
Styling improvements on general animal form
Minor bug fix in /deployments api

github-actions · 2023-10-03T18:41:14Z

Openshift URLs for the PR Deployment:

codecov · 2023-10-03T18:43:26Z

Codecov Report

Merging #1105 (9c0effd) into dev (df69dcb) will increase coverage by 0.00%.
The diff coverage is 59.09%.

@@           Coverage Diff           @@
##              dev    #1105   +/-   ##
=======================================
  Coverage   63.50%   63.50%           
=======================================
  Files         533      533           
  Lines       15817    15818    +1     
  Branches     2472     2472           
=======================================
+ Hits        10044    10046    +2     
+ Misses       5087     5086    -1     
  Partials      686      686

Files	Coverage Δ
...vey/{surveyId}/critters/{critterId}/deployments.ts	`89.09% <100.00%> (ø)`
app/src/components/buttons/HelpButtonTooltip.tsx	`50.00% <ø> (ø)`
app/src/components/fields/CbSelectFieldWrapper.tsx	`57.14% <ø> (ø)`
app/src/components/fields/TelemetrySelectField.tsx	`77.77% <ø> (ø)`
...rveys/view/survey-animals/IndividualAnimalForm.tsx	`20.00% <ø> (+5.71%)`	⬆️
.../view/survey-animals/SurveyAnimalsTableActions.tsx	`100.00% <ø> (ø)`
...urveys/view/survey-animals/TelemetryFileUpload.tsx	`50.00% <ø> (ø)`
...src/features/surveys/view/survey-animals/device.ts	`100.00% <100.00%> (ø)`
...survey-animals/form-sections/GeneralAnimalForm.tsx	`16.66% <ø> (ø)`
app/src/features/surveys/view/SurveyAnimals.tsx	`35.25% <0.00%> (-0.23%)`	⬇️
... and 3 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

api/src/paths/project/{projectId}/survey/{surveyId}/critters/{critterId}/deployments.ts

app/src/components/buttons/HelpButtonTooltip.tsx

NickPhura · 2023-10-03T20:20:14Z

I add a single animal to a survey.

When the survey page loads (just loading the survey page, not clicking anything) I'm getting the following console error:

Warning: Encountered two children with the same key, `taxon`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
div
./node_modules/@emotion/react/dist/emotion-element-c39617d8.browser.esm.js/withEmotionCache/<@http://localhost:7107/static/js/bundle.js:65443:66
div
./node_modules/@emotion/react/dist/emotion-element-c39617d8.browser.esm.js/withEmotionCache/<@http://localhost:7107/static/js/bundle.js:65443:66
GridColumnHeadersInner@http://localhost:7107/static/js/bundle.js:128052:9
div
./node_modules/@emotion/react/dist/emotion-element-c39617d8.browser.esm.js/withEmotionCache/<@http://localhost:7107/static/js/bundle.js:65443:66
GridColumnHeaders@http://localhost:7107/static/js/bundle.js:127158:9
GridColumnsHeaders@http://localhost:7107/static/js/bundle.js:123752:9
div
./node_modules/@emotion/react/dist/emotion-element-c39617d8.browser.esm.js/withEmotionCache/<@http://localhost:7107/static/js/bundle.js:65443:66
./node_modules/@mui/x-data-grid/components/containers/GridMainContainer.js/GridMainContainer<@http://localhost:7107/static/js/bundle.js:128715:100
GridBody@http://localhost:7107/static/js/bundle.js:124781:7
div
./node_modules/@emotion/react/dist/emotion-element-c39617d8.browser.esm.js/withEmotionCache/<@http://localhost:7107/static/js/bundle.js:65443:66
GridRoot@http://localhost:7107/static/js/bundle.js:128866:100
GridContextProvider@http://localhost:7107/static/js/bundle.js:133348:29
DataGrid@http://localhost:7107/static/js/bundle.js:121736:84
CustomDataGrid@http://localhost:7107/static/js/bundle.js:17329:19
SurveyAnimalsTable@http://localhost:7107/static/js/bundle.js:49264:28
div
./node_modules/@emotion/react/dist/emotion-element-c39617d8.browser.esm.js/withEmotionCache/<@http://localhost:7107/static/js/bundle.js:65443:66
Box@http://localhost:7107/static/js/bundle.js:118389:72
div
./node_modules/@emotion/react/dist/emotion-element-c39617d8.browser.esm.js/withEmotionCache/<@http://localhost:7107/static/js/bundle.js:65443:66
Box@http://localhost:7107/static/js/bundle.js:118389:72
SurveyAnimals@http://localhost:7107/static/js/bundle.js:44226:81
div
./node_modules/@emotion/react/dist/emotion-element-c39617d8.browser.esm.js/withEmotionCache/<@http://localhost:7107/static/js/bundle.js:65443:66
Paper@http://localhost:7107/static/js/bundle.js:103888:83
div
./node_modules/@emotion/react/dist/emotion-element-c39617d8.browser.esm.js/withEmotionCache/<@http://localhost:7107/static/js/bundle.js:65443:66
Box@http://localhost:7107/static/js/bundle.js:118389:72
div
./node_modules/@emotion/react/dist/emotion-element-c39617d8.browser.esm.js/withEmotionCache/<@http://localhost:7107/static/js/bundle.js:65443:66
Grid@http://localhost:7107/static/js/bundle.js:97032:87
div
./node_modules/@emotion/react/dist/emotion-element-c39617d8.browser.esm.js/withEmotionCache/<@http://localhost:7107/static/js/bundle.js:65443:66
Grid@http://localhost:7107/static/js/bundle.js:97032:87
div
./node_modules/@emotion/react/dist/emotion-element-c39617d8.browser.esm.js/withEmotionCache/<@http://localhost:7107/static/js/bundle.js:65443:66
Box@http://localhost:7107/static/js/bundle.js:118389:72
div
./node_modules/@emotion/react/dist/emotion-element-c39617d8.browser.esm.js/withEmotionCache/<@http://localhost:7107/static/js/bundle.js:65443:66
Container@http://localhost:7107/static/js/bundle.js:117455:32
SurveyPage@http://localhost:7107/static/js/bundle.js:46042:73
div
./node_modules/@emotion/react/dist/emotion-element-c39617d8.browser.esm.js/withEmotionCache/<@http://localhost:7107/static/js/bundle.js:65443:66
Box@http://localhost:7107/static/js/bundle.js:118389:72
div
./node_modules/@emotion/react/dist/emotion-element-c39617d8.browser.esm.js/withEmotionCache/<@http://localhost:7107/static/js/bundle.js:65443:66
Box@http://localhost:7107/static/js/bundle.js:118389:72
ProjectsLayout@http://localhost:7107/static/js/bundle.js:60594:19
Route@http://localhost:7107/static/js/bundle.js:274891:29
RouteWithTitle@http://localhost:7107/static/js/bundle.js:63199:7
Switch@http://localhost:7107/static/js/bundle.js:275060:29
SurveyRouter
ObservationsContextProvider@http://localhost:7107/static/js/bundle.js:19543:93
SurveyContextProvider@http://localhost:7107/static/js/bundle.js:20004:85
Route@http://localhost:7107/static/js/bundle.js:274891:29
CheckIfUserHasProjectRole@http://localhost:7107/static/js/bundle.js:16904:7
WaitForProjectParticipantInfo@http://localhost:7107/static/js/bundle.js:16749:84
ProjectRoleRouteGuard@http://localhost:7107/static/js/bundle.js:16579:7
div
./node_modules/@emotion/react/dist/emotion-element-c39617d8.browser.esm.js/withEmotionCache/<@http://localhost:7107/static/js/bundle.js:65443:66
Box@http://localhost:7107/static/js/bundle.js:118389:72
div
./node_modules/@emotion/react/dist/emotion-element-c39617d8.browser.esm.js/withEmotionCache/<@http://localhost:7107/static/js/bundle.js:65443:66
Box@http://localhost:7107/static/js/bundle.js:118389:72
ProjectsLayout@http://localhost:7107/static/js/bundle.js:60594:19
Route@http://localhost:7107/static/js/bundle.js:274891:29
RouteWithTitle@http://localhost:7107/static/js/bundle.js:63199:7
ProjectContextProvider@http://localhost:7107/static/js/bundle.js:19881:85
ProjectAuthStateContextProvider@http://localhost:7107/static/js/bundle.js:19729:85
Route@http://localhost:7107/static/js/bundle.js:274891:29
RouteWithTitle@http://localhost:7107/static/js/bundle.js:63199:7
Switch@http://localhost:7107/static/js/bundle.js:275060:29
ProjectsRouter
CodesContextProvider@http://localhost:7107/static/js/bundle.js:19055:85
Route@http://localhost:7107/static/js/bundle.js:274891:29
CheckIfAuthenticatedUser@http://localhost:7107/static/js/bundle.js:16779:56
WaitForKeycloakToLoadUserInfo@http://localhost:7107/static/js/bundle.js:16715:39
CheckForKeycloakAuthenticated@http://localhost:7107/static/js/bundle.js:16686:56
AuthenticatedRouteGuard@http://localhost:7107/static/js/bundle.js:16616:7
main
./node_modules/@emotion/react/dist/emotion-element-c39617d8.browser.esm.js/withEmotionCache/<@http://localhost:7107/static/js/bundle.js:65443:66
Box@http://localhost:7107/static/js/bundle.js:118389:72
DialogContextProvider@http://localhost:7107/static/js/bundle.js:19367:98
div
./node_modules/@emotion/react/dist/emotion-element-c39617d8.browser.esm.js/withEmotionCache/<@http://localhost:7107/static/js/bundle.js:65443:66
Box@http://localhost:7107/static/js/bundle.js:118389:72
BaseLayout@http://localhost:7107/static/js/bundle.js:60464:19
Route@http://localhost:7107/static/js/bundle.js:274891:29
RouteWithTitle@http://localhost:7107/static/js/bundle.js:63199:7
Switch@http://localhost:7107/static/js/bundle.js:275060:29
AppRouter@http://localhost:7107/static/js/bundle.js:213:82
Router@http://localhost:7107/static/js/bundle.js:274563:30
BrowserRouter@http://localhost:7107/static/js/bundle.js:274078:35
AuthStateContextProvider@http://localhost:7107/static/js/bundle.js:18966:95
KeycloakProvider@http://localhost:7107/static/js/bundle.js:161152:47
ConfigContextProvider@http://localhost:7107/static/js/bundle.js:19216:78
ThemeProvider@http://localhost:7107/static/js/bundle.js:115989:7
ThemeProvider@http://localhost:7107/static/js/bundle.js:117623:7
ThemeProvider@http://localhost:7107/static/js/bundle.js:114273:9
App

(tested on my local)

NickPhura · 2023-10-03T20:21:43Z

Also, I'm getting a 503 error from the http://localhost:6107/api/project/1/survey/1/deployments endpoint when the survey page loads.

(tested on my local)

app/src/features/surveys/view/survey-animals/form-sections/GeneralAnimalForm.tsx

al-rosenthal

I'm seeing a 500 on the deployments api call when a survey loads. Am I missing some sort of setup for testing this?

hit the wrong button

sonarqubecloud · 2023-10-03T23:18:43Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

* Updated HelpButtonTooltip styling * Cleaned up CbSelectField and TelemetrySelectField components * Updated SurveyAnimalsI18N messages * Updated mui components and helper messages in SurveyAnimals component * Cleaned up dead code in IndividualAnimalForm * Improved formatting in SurveyAnimalsTable * Several changes to TelemetryDeviceForm including mui components, overall layout, conditional formatting * Several changes to FormSectionWrapper including overall layout, styling, and mui components * Improved styling in GeneralAnimalForm --------- Co-authored-by: jeznorth <[email protected]>

jeznorth and others added 11 commits September 27, 2023 13:51

Telemetry UI Updates

48de997

UI Updates

27d5998

UI Updates

6d67f2c

UI Updates

f4b986b

UI Updates

39eb4e0

Merge branch 'dev' into telemetry-ui-updates

02e029b

Updated styling of Telemetry upload component

8786d6a

Refresh attachments on telemetry save

cfc43c5

Added optional text

218a844

Fixed deployment response object bug

051dbb1

Merge branch 'dev' into telemetry-ui-updates

06566c6

JeremyQuartech added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Oct 3, 2023

Lint fixes

04bc8b2

NickPhura reviewed Oct 3, 2023

View reviewed changes

api/src/paths/project/{projectId}/survey/{surveyId}/critters/{critterId}/deployments.ts Outdated Show resolved Hide resolved

NickPhura reviewed Oct 3, 2023

View reviewed changes

app/src/components/buttons/HelpButtonTooltip.tsx Outdated Show resolved Hide resolved

GrahamS-Quartech reviewed Oct 3, 2023

View reviewed changes

app/src/features/surveys/view/survey-animals/form-sections/GeneralAnimalForm.tsx Show resolved Hide resolved

JeremyQuartech added 3 commits October 3, 2023 14:16

Addressed PR comments

d9e3f90

Removed duplicate 'taxon' column in known animals table

0aa3502

Fixed survey animals test timeout bug

e69643e

al-rosenthal previously approved these changes Oct 3, 2023

View reviewed changes

changed BCTW_API_HOST from prod to dev

9c0effd

GrahamS-Quartech approved these changes Oct 3, 2023

View reviewed changes

NickPhura approved these changes Oct 3, 2023

View reviewed changes

JeremyQuartech merged commit ab2019d into dev Oct 3, 2023

NickPhura deleted the telemetry-ui-updates branch October 3, 2023 23:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Telemetry UI Updates #1105

Telemetry UI Updates #1105

JeremyQuartech commented Oct 3, 2023

github-actions bot commented Oct 3, 2023

codecov bot commented Oct 3, 2023 •

edited

Loading

NickPhura commented Oct 3, 2023 •

edited

Loading

NickPhura commented Oct 3, 2023 •

edited

Loading

al-rosenthal left a comment •

edited

Loading

sonarqubecloud bot commented Oct 3, 2023

Telemetry UI Updates #1105

Telemetry UI Updates #1105

Conversation

JeremyQuartech commented Oct 3, 2023

Description of Changes

github-actions bot commented Oct 3, 2023

codecov bot commented Oct 3, 2023 • edited Loading

Codecov Report

NickPhura commented Oct 3, 2023 • edited Loading

NickPhura commented Oct 3, 2023 • edited Loading

al-rosenthal left a comment • edited Loading

Choose a reason for hiding this comment

sonarqubecloud bot commented Oct 3, 2023

codecov bot commented Oct 3, 2023 •

edited

Loading

NickPhura commented Oct 3, 2023 •

edited

Loading

NickPhura commented Oct 3, 2023 •

edited

Loading

al-rosenthal left a comment •

edited

Loading