SIMSBIOHUB-276: Remove Lead Biologist from survey edit and create page

[curtisupshall]

Links to Jira Tickets

• https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-276

Description of Changes

• Removes survey lead biologist from frontend and backend code
• Adds a migration to fix the survey delete procedure
• Fixes issues with the Observations Table

Testing Notes

You should be able to:

• Create a survey
• Edit a survey
• Ddelete a survey

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1108-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1108-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1108

[codecov]

Codecov Report

Merging #1108 (9961285) into dev (73681f3) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev    #1108      +/-   ##
==========================================
- Coverage   63.30%   63.29%   -0.02%     
==========================================
  Files         531      531              
  Lines       15786    15781       -5     
  Branches     2445     2439       -6     
==========================================
- Hits         9994     9988       -6     
- Misses       5107     5108       +1     
  Partials      685      685              

Files	Coverage Δ
api/src/models/survey-create.ts	77.96% <ø> (-0.73%)	⬇️
api/src/models/survey-update.ts	80.64% <ø> (-0.61%)	⬇️
api/src/models/survey-view.ts	82.85% <ø> (-0.48%)	⬇️
api/src/paths/project/{projectId}/survey/create.ts	96.15% <ø> (ø)
api/src/paths/project/{projectId}/survey/list.ts	96.66% <ø> (ø)
...hs/project/{projectId}/survey/{surveyId}/update.ts	96.29% <ø> (ø)
...roject/{projectId}/survey/{surveyId}/update/get.ts	84.37% <ø> (ø)
...aths/project/{projectId}/survey/{surveyId}/view.ts	95.83% <ø> (ø)
api/src/repositories/survey-repository.ts	96.77% <ø> (ø)
...ures/surveys/components/GeneralInformationForm.tsx	20.83% <ø> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1108-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1108-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1108

[al-rosenthal]

ran this locally and everything works 🛠️

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
8.3% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[JeremyQuartech]

Code looks good. Everything is working as expected on my local 🐸

[al-rosenthal]

🐕