Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animal Form UI Fixes #1109

Merged
merged 8 commits into from
Oct 5, 2023
Merged

Animal Form UI Fixes #1109

merged 8 commits into from
Oct 5, 2023

Conversation

JeremyQuartech
Copy link
Contributor

Description of Changes

  • Removed Animal count indicator from dialog title
  • Added "ID" as subtitle when editing an animal
  • Removed "Created On" column from animal table
  • Renamed "Edit Critter Details" action to "Edit Animal"

Testing Notes

  • Changes can be observed by adding a new animal to a survey and editing an animal in a survey

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Openshift URLs for the PR Deployment:

@JeremyQuartech JeremyQuartech changed the title Animal form UI fixes Animal Form UI Fixes Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

Merging #1109 (401f873) into dev (d4aa9c4) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##              dev    #1109      +/-   ##
==========================================
- Coverage   63.29%   63.28%   -0.01%     
==========================================
  Files         531      531              
  Lines       15781    15777       -4     
  Branches     2439     2438       -1     
==========================================
- Hits         9988     9985       -3     
+ Misses       5108     5106       -2     
- Partials      685      686       +1
Files Coverage Δ
app/src/components/buttons/HelpButtonTooltip.tsx 50.00% <100.00%> (ø)
...rveys/view/survey-animals/IndividualAnimalForm.tsx 33.33% <100.00%> (+13.33%) ⬆️
...surveys/view/survey-animals/SurveyAnimalsTable.tsx 66.66% <ø> (-3.34%) ⬇️
.../view/survey-animals/SurveyAnimalsTableActions.tsx 100.00% <ø> (ø)
app/src/features/surveys/view/SurveyAnimals.tsx 34.61% <0.00%> (-0.65%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

al-rosenthal
al-rosenthal approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JeremyQuartech JeremyQuartech merged commit 23374a8 into dev Oct 5, 2023
@JeremyQuartech JeremyQuartech deleted the animal-form-ui-fixes branch October 5, 2023 20:07
KjartanE pushed a commit that referenced this pull request Oct 6, 2023
@JeremyQuartech @KjartanE
Animal Form UI Fixes (#1109)
09657fb 
* Removed Animal count indicator from animal dialog title
* Added "ID" as subtitle when editing an animal
* Removed "Created On" column from animal table
* Renamed "Edit Critter Details" action to "Edit Animal"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtisupshall curtisupshall curtisupshall left review comments

@al-rosenthal al-rosenthal al-rosenthal approved these changes

@NickPhura NickPhura NickPhura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeremyQuartech @NickPhura @al-rosenthal @curtisupshall