Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-308: System API User Add Bug #1127

Merged
merged 7 commits into from
Oct 19, 2023
Merged

SIMSBIOHUB-308: System API User Add Bug #1127

merged 7 commits into from
Oct 19, 2023

Conversation

KjartanE
Copy link
Contributor

Links to Jira Tickets

Description of Changes

  • On PR 194, some work surrounding user auth and adding was accidentally overwritten. This PR is to fix that mistake and update users properly. The overwritten PR is 154

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

@NickPhura NickPhura changed the title System API User add bug BugFixes: System API User Add Bug Oct 18, 2023
@NickPhura NickPhura changed the title BugFixes: System API User Add Bug SIMSBIOHUB-308: System API User Add Bug Oct 18, 2023
api/src/database/db.ts Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1127 (e4f9c78) into dev (2960d9b) will increase coverage by 0.07%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##              dev    #1127      +/-   ##
==========================================
+ Coverage   63.09%   63.16%   +0.07%     
==========================================
  Files         536      536              
  Lines       16325    16367      +42     
  Branches     2510     2516       +6     
==========================================
+ Hits        10301    10339      +38     
- Misses       5333     5334       +1     
- Partials      691      694       +3     
Files Coverage Δ
api/src/database/db-utils.ts 83.87% <100.00%> (+8.87%) ⬆️
api/src/services/authorization-service.ts 99.06% <100.00%> (+0.01%) ⬆️
app/src/hooks/useKeycloakWrapper.tsx 70.58% <100.00%> (ø)
api/src/paths/user/add.ts 56.41% <50.00%> (ø)
api/src/utils/keycloak-utils.ts 88.46% <97.29%> (+1.36%) ⬆️
api/src/database/db.ts 78.15% <80.00%> (-0.23%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. 🛠

@KjartanE KjartanE merged commit 69f4781 into dev Oct 19, 2023
20 checks passed
@KjartanE KjartanE deleted the user-bug-fix-2 branch October 19, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants