SIMSBIOHUB 347/341 - Names from shapefiles #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame and description fields from geometry passed to the insert sample location endpoint.
|
Openshift URLs for the PR Deployment: |
Codecov Report
@@ Coverage Diff @@
## dev-staging #1146 +/- ##
===============================================
- Coverage 62.13% 62.11% -0.02%
===============================================
Files 554 554
Lines 16914 16940 +26
Branches 2598 2605 +7
===============================================
+ Hits 10510 10523 +13
- Misses 5697 5705 +8
- Partials 707 712 +5
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
GrahamS-Quartech
changed the title
al-rosenthal
approved these changes
Oct 27, 2023
NickPhura
reviewed
Oct 27, 2023
app/src/features/surveys/observations/sampling-sites/edit/components/SampleSiteEditForm.tsx
Outdated
Show resolved
Hide resolved
NickPhura
reviewed
Oct 27, 2023
…logic, updated naming and types, provided better message for max char field requirement
|
Kudos, SonarCloud Quality Gate passed!
|
JeremyQuartech
approved these changes
Oct 31, 2023
KjartanE
pushed a commit
that referenced
this pull request
Nov 6, 2023
* Added some additional logic to the API to extract a name and description from the provided shape file when creating sampling sites. * It will search the keys of the geometry's properties for "name" or "label" and "des" or "desc" or "descr" (exact match), then use the value for the sampling site name and description respectively. * Added a character limit to the sampling site name field in the edit form. --------- Co-authored-by: JeremyQuartech <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
Description of Changes
Testing Notes
OminecaShapefile.zip's properties are an example of something that won't be picked up by this approach.62_Features_Shapefile.zipproperties will be used by this approach.