SIMSBIOHUB 335: Tab Through Observation Edit #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elements in the edit view of the observations table to be Tab / Shift+Tab through
|
Openshift URLs for the PR Deployment: |
Codecov Report
@@ Coverage Diff @@
## dev-staging #1156 +/- ##
===============================================
- Coverage 61.87% 61.81% -0.06%
===============================================
Files 547 549 +2
Lines 16597 16639 +42
Branches 2540 2541 +1
===============================================
+ Hits 10269 10286 +17
- Misses 5645 5665 +20
- Partials 683 688 +5
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
al-rosenthal
reviewed
Nov 1, 2023
app/src/components/data-grid/autocomplete/AsyncAutocompleteDataGridEditCell.tsx
Outdated
Show resolved
Hide resolved
app/src/components/data-grid/autocomplete/AutocompleteDataGridEditCell.tsx
Outdated
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed.
|
curtisupshall
approved these changes
Nov 1, 2023
JeremyQuartech
approved these changes
Nov 1, 2023
|
Openshift URLs for the PR Deployment: |
KjartanE
pushed a commit
that referenced
this pull request
Nov 6, 2023
* Modified each custom renderEditCell component of the ObservationTable to manually set hasFocus. This allows the user to Tab forward to the next cell or Shift+Tab back to the previous. * Wrapped some of the simpler TextField / DatePicker renders in their own functional components so that the same hasFocus pattern could be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
Description of Changes