SIMSBIOHUB-188 - Manage Animals

[MacQSL]

Links to Jira Tickets

-SIMSBIOHUB-188

Description of Changes

• Overhauled the Edit Animal modal to be a full screen page instead. Accessed through the Manage Animals button on a survey.
• Animals in this view appear listed in the sidebar by their alias. Clicking on one of these items opens an accordion to the various form sections.
• Each form section has been adapted into a list of static cards. You can edit or delete cards from the relevant button icons. You can also add another card from the top of the page. Clicking the add or edit buttons brings up a form modal that will send a request on submission of the form.
• Deleting any card should prompt a confirm delete modal.
• Telemetry devices still work slightly differently than the rest of this page in that device and deployments get added together and deployments can be deleted but devices cannot. It's fairly consistently integrated otherwise.
• Currently all sections hit the bulk endpoint in Critterbase (allows multiple sections to be added at once).

Testing Notes

• should be able to create and edit all sections
• Telemetry section is still in flux and will be moved out in upcoming telemetry UI tickets.

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1171-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1171-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1171

[codecov]

Codecov Report

Attention: 341 lines in your changes are missing coverage. Please review.

Comparison is base (ae0b035) 61.03% compared to head (8ab342a) 60.82%.

Files	Patch %	Lines
.../surveys/view/survey-animals/SurveyAnimalsPage.tsx	22.96%	103 Missing and 1 partial ⚠️
...animals/telemetry-device/DeploymentFormSection.tsx	2.00%	49 Missing ⚠️
...eys/view/survey-animals/AnimalSectionDataCards.tsx	44.61%	34 Missing and 2 partials ⚠️
...ures/surveys/view/survey-animals/AddEditAnimal.tsx	62.06%	18 Missing and 4 partials ⚠️
...ls/telemetry-device/TelemetryDeviceFormContent.tsx	4.34%	22 Missing ⚠️
...survey-animals/form-sections/LocationEntryForm.tsx	0.00%	21 Missing ⚠️
...survey-animals/form-sections/MarkingAnimalForm.tsx	35.00%	13 Missing ⚠️
...ey-animals/form-sections/MeasurementAnimalForm.tsx	52.00%	10 Missing and 2 partials ⚠️
...surveys/view/survey-animals/animal-form-helpers.ts	8.33%	4 Missing and 7 partials ⚠️
...survey-animals/form-sections/CaptureAnimalForm.tsx	12.50%	7 Missing ⚠️
... and 16 more

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #1171      +/-   ##
==========================================
- Coverage   61.03%   60.82%   -0.22%     
==========================================
  Files         554      562       +8     
  Lines       16809    16962     +153     
  Branches     2587     2626      +39     
==========================================
+ Hits        10260    10317      +57     
- Misses       5869     5959      +90     
- Partials      680      686       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[curtisupshall]

Code looks good! Had a handful of minor comments

[curtisupshall]

Had another look at the code. LGTM!

[al-rosenthal]

I tested this locally and found a few small things:

• when adding a measurement with a count I can trick the validator with 1 1 but it causes an API error
• The event date in Mortality events is not marked as required but it validates as such

[al-rosenthal]

looks good! 🐘

[al-rosenthal]

🐊

[al-rosenthal]

🏈

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication