Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-379: Dataset object generation fix for geometry #1179

Merged
merged 9 commits into from
Dec 15, 2023

Conversation

KjartanE
Copy link
Contributor

@KjartanE KjartanE commented Dec 7, 2023

Description of Changes

  • Validation quick fix for dataset geometry

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

@KjartanE KjartanE changed the title Dataset object generation fix for geometry SIMSBIOHUB-379: Dataset object generation fix for geometry Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (90b0557) 58.15% compared to head (30cbbd6) 58.15%.

Files Patch % Lines
api/src/services/platform-service.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1179      +/-   ##
==========================================
- Coverage   58.15%   58.15%   -0.01%     
==========================================
  Files         590      590              
  Lines       17943    17945       +2     
  Branches     2763     2762       -1     
==========================================
+ Hits        10435    10436       +1     
- Misses       6824     6825       +1     
  Partials      684      684              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curtisupshall curtisupshall self-assigned this Dec 7, 2023
NickPhura and others added 2 commits December 7, 2023 11:19
* Adjust API memory settings, set node env properly, adjust log levels
* Simplify zod geojson schema
* Remove zod from keycloak token type definitions (hotspot).
Disable zod database response parsing in production.
Add query and zod timers in development.
* BugFix: Allow surveys to be created with $0 amounts.
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried running this locally and ran into an issue once the data hit BioHub. The error in the biohub API was "publish_timestamp" of relation "submission" does not exist. My Biohub app was running off of the feature branch dataset_security_feature

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

1 similar comment
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@NickPhura NickPhura merged commit 7bfbf9c into dev Dec 15, 2023
18 of 19 checks passed
@NickPhura NickPhura deleted the SIMSBIOHUB-379 branch December 15, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants