Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-419: Invalid Observation Upload #1183

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

al-rosenthal
Copy link
Contributor

@al-rosenthal al-rosenthal commented Dec 14, 2023

Links to Jira Tickets

SIMSBIOHUB-419

Description of Changes

  • Fixed check that was incorrectly flagging files as invalid

Testing Notes

  • Create a survey
  • Click Manage Observations
  • Grab supplied_observations.csv from discord and upload

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8c66d58) 58.15% compared to head (dbeb550) 58.15%.

Files Patch % Lines
api/src/services/observation-service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1183   +/-   ##
=======================================
  Coverage   58.15%   58.15%           
=======================================
  Files         590      590           
  Lines       17943    17943           
  Branches     2763     2763           
=======================================
  Hits        10435    10435           
  Misses       6824     6824           
  Partials      684      684           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@al-rosenthal al-rosenthal merged commit 90b0557 into dev Dec 14, 2023
19 of 20 checks passed
@al-rosenthal al-rosenthal deleted the BugFix-ObservationUpload branch December 14, 2023 17:50
al-rosenthal added a commit that referenced this pull request Dec 14, 2023
Fixed bug with observation upload process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants