-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TechDebt: Add Support For Authorization By Survey ID #1186
Conversation
Update all paths under {surveyId} to use survey id based authorization.
Openshift URLs for the PR Deployment: |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #1186 +/- ##
==========================================
+ Coverage 58.16% 58.19% +0.03%
==========================================
Files 590 590
Lines 17964 17985 +21
Branches 2767 2773 +6
==========================================
+ Hits 10448 10466 +18
- Misses 6831 6833 +2
- Partials 685 686 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐈 Ran locally, functioned properly
Quality Gate failedFailed conditions 8.6% Duplication on New Code (required ≤ 3%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🛺
Links to Jira Tickets
n/a
Description of Changes
../{surveyId}
to use survey id based authorization.Testing Notes
../paths/..
changes are just to update to auth check to use survey id instead of project id.Everything should work as before.