Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-403: Telemetry Table Upload #1187

Merged
merged 118 commits into from
Jan 16, 2024
Merged

SIMSBIOHUB-403: Telemetry Table Upload #1187

merged 118 commits into from
Jan 16, 2024

Conversation

al-rosenthal
Copy link
Contributor

@al-rosenthal al-rosenthal commented Jan 2, 2024

Links to Jira Tickets

SIMSBIOHUB-403

Description of Changes

  • Added support for telemetry table to upload CSV files

Testing Notes

  • The linked ticket has an example file that can be uploaded
  • The column validation will work similar to the observations (lat, latitude are both acceptable)
  • If no deployment can be found from the uploaded data, an error will be thrown and the process will be stopped

Steps to test:

  1. Once the app is running, navigate to a survey
  2. Create an animal in the Marked and Known Animals section
  3. Back at the survey, open the telemetry table with the Manage Telemetry button
  4. Add a deployment with the Add button in the left hand panel, select the animal you created earlier
  5. Copy the device ID from the created deployment and remember the dates associated to the deployment
  6. Download and open the supplied_telemetry on the ticket
  7. Modify device id column in the csv file with the one you copied earlier
  8. Ensure the dates in the file also fit within the date range on the deployment
  9. Upload that CSV file

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (197400b) 0.00% compared to head (9985bb1) 58.02%.

Files Patch % Lines
api/src/services/telemetry-service.ts 0.00% 33 Missing ⚠️
...res/surveys/telemetry/ManualTelemetryComponent.tsx 0.00% 3 Missing ⚠️
api/src/paths/telemetry/manual/process.ts 0.00% 2 Missing ⚠️
.../{projectId}/survey/{surveyId}/telemetry/upload.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           dev    #1187       +/-   ##
========================================
+ Coverage     0   58.02%   +58.02%     
========================================
  Files        0      591      +591     
  Lines        0    18093    +18093     
  Branches     0     2785     +2785     
========================================
+ Hits         0    10499    +10499     
- Misses       0     6907     +6907     
- Partials     0      687      +687     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KjartanE KjartanE self-assigned this Jan 5, 2024
@KjartanE
Copy link
Contributor

KjartanE commented Jan 5, 2024

Confusion around errors when uploading csv file. Better error handling required for when device id in already in use, and date range is incorrect.
Import functioned correctly when deployment record was properly set.

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈

@KjartanE KjartanE merged commit 8a673b3 into dev Jan 16, 2024
19 checks passed
@KjartanE KjartanE deleted the SIMSBIOHUB-403 branch January 16, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants