TechDebt: Minor Openapi and JSDoc Fixes #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Openshift URLs for the PR Deployment: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1188 +/- ##
=======================================
Coverage 58.18% 58.18%
=======================================
Files 590 590
Lines 17987 17987
Branches 2774 2774
=======================================
Hits 10466 10466
Misses 6835 6835
Partials 686 686 ☔ View full report in Codecov by Sentry. |
|
KjartanE
approved these changes
Jan 4, 2024
KjartanE
pushed a commit
that referenced
this pull request
Jan 5, 2024
* Update bad oopenapi request error number * Fix old jsdoc * Port local dev node options env var change from BioHub * Remove duplicate docker-compose env var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
n/a
Description of Changes
Update openapi spec for the list of errors (the 403 error was referring to the the 401 object).
Update jsdoc for frontend api functions.
Testing Notes
Everything works as normal (none of these changes should actually impact the code at all anyways).