Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TechDebt: Moment -> DayJs #1189

Merged
merged 6 commits into from
Jan 4, 2024
Merged

TechDebt: Moment -> DayJs #1189

merged 6 commits into from
Jan 4, 2024

Conversation

al-rosenthal
Copy link
Contributor

Links to Jira Tickets

Description of Changes

  • Replaced moment with dayjs

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (5517e88) 58.19% compared to head (2a64f0c) 58.18%.

Files Patch % Lines
app/src/utils/YupSchema.ts 0.00% 11 Missing ⚠️
app/src/components/fields/DateTimeFields.tsx 0.00% 5 Missing ⚠️
...ervations/observations-table/ObservationsTable.tsx 0.00% 5 Missing ⚠️
...eatures/surveys/telemetry/ManualTelemetryTable.tsx 0.00% 5 Missing ⚠️
app/src/utils/Utils.tsx 58.33% 4 Missing and 1 partial ⚠️
app/src/components/fields/StartEndDateFields.tsx 0.00% 4 Missing ⚠️
app/src/components/fields/SingleDateField.tsx 0.00% 2 Missing ⚠️
...surveys/view/survey-animals/SurveyAnimalsTable.tsx 0.00% 0 Missing and 2 partials ⚠️
api/src/utils/xlsx-utils/worksheet-utils.ts 50.00% 1 Missing ⚠️
...pp/src/components/data-grid/DatePickerDataGrid.tsx 0.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1189      +/-   ##
==========================================
- Coverage   58.19%   58.18%   -0.01%     
==========================================
  Files         590      590              
  Lines       17985    17987       +2     
  Branches     2773     2774       +1     
==========================================
  Hits        10466    10466              
- Misses       6833     6835       +2     
  Partials      686      686              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

NickPhura
NickPhura previously approved these changes Jan 3, 2024
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just navigated through the deployed app a bit, and messed with a few things (edited a survey and funding source, etc). Everything seems happy.

Looks like dayjs is basically a drop-in replacement for moment?

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌞

Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

7.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@NickPhura NickPhura merged commit bea81bf into dev Jan 4, 2024
16 of 19 checks passed
@NickPhura NickPhura deleted the TechDebt-DayJS branch January 4, 2024 21:04
KjartanE pushed a commit that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants