Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-395-2: Select all bulk delete sample sites #1192

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Conversation

KjartanE
Copy link
Contributor

Links to Jira Tickets

Description of Changes

  • {List all relevant code changes. Include any changes to the business workflow that might not be obvious to the reviewers of this PR.}

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (76bc44a) 58.16% compared to head (ef63c20) 58.12%.

Files Patch % Lines
...s/observations/sampling-sites/SamplingSiteList.tsx 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1192      +/-   ##
==========================================
- Coverage   58.16%   58.12%   -0.05%     
==========================================
  Files         591      591              
  Lines       18049    18062      +13     
  Branches     2777     2780       +3     
==========================================
  Hits        10499    10499              
- Misses       6863     6876      +13     
  Partials      687      687              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curtisupshall curtisupshall self-assigned this Jan 12, 2024
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on remote, seems to work as intended 👍

@jeznorth jeznorth self-requested a review January 12, 2024 18:53
Copy link
Contributor

@jeznorth jeznorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete works as expected.

nit: The delete button in the dialog should be replaced with a loading button, I can send multiple requests before the dialog closes causes the error snack bar to display.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐

@KjartanE KjartanE merged commit 197400b into dev Jan 15, 2024
17 of 19 checks passed
@KjartanE KjartanE deleted the SIMSBIOHUB-395-2 branch January 15, 2024 17:27
KjartanE added a commit that referenced this pull request Jan 15, 2024
* bulk delete sample sites, select all
* pr edit, add indeterminate on checkbox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants