-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMSBIOHUB-395-2: Select all bulk delete sample sites #1192
Conversation
Openshift URLs for the PR Deployment: |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #1192 +/- ##
==========================================
- Coverage 58.16% 58.12% -0.05%
==========================================
Files 591 591
Lines 18049 18062 +13
Branches 2777 2780 +3
==========================================
Hits 10499 10499
- Misses 6863 6876 +13
Partials 687 687 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on remote, seems to work as intended 👍
app/src/features/surveys/observations/sampling-sites/SamplingSiteList.tsx
Show resolved
Hide resolved
app/src/features/surveys/observations/sampling-sites/SamplingSiteList.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete works as expected.
nit: The delete button in the dialog should be replaced with a loading button, I can send multiple requests before the dialog closes causes the error snack bar to display.
app/src/features/surveys/observations/sampling-sites/SamplingSiteList.tsx
Outdated
Show resolved
Hide resolved
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐐
* bulk delete sample sites, select all * pr edit, add indeterminate on checkbox
Links to Jira Tickets
Description of Changes
Testing Notes