Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Updates #1194

Merged
merged 12 commits into from
Jan 16, 2024
Merged

UI Updates #1194

merged 12 commits into from
Jan 16, 2024

Conversation

jeznorth
Copy link
Contributor

Description of Changes

  • Standardize markup / layouts for observations, telemetry and animal interfaces.
  • Included fixes to standardize header components across various pages

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (8a673b3) 58.02% compared to head (ff4bbb4) 57.80%.

Files Patch % Lines
...s/observations/sampling-sites/SamplingSiteList.tsx 0.00% 16 Missing ⚠️
app/src/components/loading/SkeletonLoaders.tsx 0.00% 7 Missing ⚠️
...res/surveys/telemetry/ManualTelemetryComponent.tsx 0.00% 7 Missing ⚠️
app/src/features/projects/view/ProjectHeader.tsx 0.00% 4 Missing ⚠️
...src/features/projects/create/CreateProjectPage.tsx 0.00% 2 Missing ⚠️
...es/funding-sources/list/FundingSourcesListPage.tsx 0.00% 1 Missing ⚠️
...features/surveys/telemetry/ManualTelemetryList.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1194      +/-   ##
==========================================
- Coverage   58.02%   57.80%   -0.22%     
==========================================
  Files         591      591              
  Lines       18093    18080      -13     
  Branches     2785     2785              
==========================================
- Hits        10499    10452      -47     
- Misses       6907     6940      +33     
- Partials      687      688       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
No data about Coverage
1.5% Duplication on New Code

See analysis details on SonarCloud

@jeznorth jeznorth requested review from al-rosenthal and removed request for MacQSL January 16, 2024 21:27
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@al-rosenthal al-rosenthal merged commit d372898 into dev Jan 16, 2024
17 of 19 checks passed
@al-rosenthal al-rosenthal deleted the UI-Updates branch January 16, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants