Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-451: Recognize 'Species' column in uploaded observation CSV #1196

Merged
merged 5 commits into from
Jan 18, 2024

Conversation

curtisupshall
Copy link
Contributor

Links to Jira Tickets

Description of Changes

Observation CSV uploads now expect the species column to be named Species, rather than SPECIES_TAXONOMIC_ID.

Testing Notes

Upload an observations CSV, ensuring that the species column is titled Species (case insensitive). You should:

  • See that the upload was successful.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87ebaeb) 57.80% compared to head (41017e8) 57.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1196   +/-   ##
=======================================
  Coverage   57.80%   57.80%           
=======================================
  Files         591      591           
  Lines       18080    18080           
  Branches     2785     2785           
=======================================
  Hits        10452    10452           
  Misses       6940     6940           
  Partials      688      688           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KjartanE
KjartanE previously approved these changes Jan 17, 2024
Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈

KjartanE
KjartanE previously approved these changes Jan 17, 2024
Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈

NickPhura
NickPhura previously approved these changes Jan 18, 2024
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦫

@NickPhura NickPhura dismissed stale reviews from KjartanE and themself via 41017e8 January 18, 2024 19:04
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐱

@curtisupshall curtisupshall merged commit 90b1b20 into dev Jan 18, 2024
19 checks passed
@curtisupshall curtisupshall deleted the SIMSBIOHUB-451 branch January 18, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants