Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-444, 456 - Shared Documents rename; No Deployments placeholder #1197

Merged
merged 6 commits into from
Jan 18, 2024

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Jan 18, 2024

Links to Jira Tickets

Description of Changes

  • SIMSBIOHUB-444: Renamed project Documents to 'Shared Files'.
  • SIMSBIOHUB-456: Shows empty state ("No Deployments") for deployments listed on telemetry page.
  • Minor UI tweaks

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (90b1b20) 57.80% compared to head (3bb551f) 57.80%.

Files Patch % Lines
...features/surveys/telemetry/ManualTelemetryList.tsx 0.00% 5 Missing ⚠️
...s/observations/sampling-sites/SamplingSiteList.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1197      +/-   ##
==========================================
- Coverage   57.80%   57.80%   -0.01%     
==========================================
  Files         591      591              
  Lines       18080    18082       +2     
  Branches     2785     2788       +3     
==========================================
  Hits        10452    10452              
- Misses       6940     6942       +2     
  Partials      688      688              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jeznorth
jeznorth previously approved these changes Jan 18, 2024
Copy link
Contributor

@jeznorth jeznorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the documents section of the survey page also be called 'Shared Files'?

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (only did a static look over)

@curtisupshall
Copy link
Contributor Author

Should the documents section of the survey page also be called 'Shared Files'?

Negative. Just for Projects.

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👾

@curtisupshall curtisupshall merged commit c93d780 into dev Jan 18, 2024
17 of 19 checks passed
@curtisupshall curtisupshall deleted the SIMSBIOHUB-444-456 branch January 18, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants