-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMSBIOHUB-444, 456 - Shared Documents rename; No Deployments placeholder #1197
Conversation
Openshift URLs for the PR Deployment: |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #1197 +/- ##
==========================================
- Coverage 57.80% 57.80% -0.01%
==========================================
Files 591 591
Lines 18080 18082 +2
Branches 2785 2788 +3
==========================================
Hits 10452 10452
- Misses 6940 6942 +2
Partials 688 688 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the documents section of the survey page also be called 'Shared Files'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (only did a static look over)
Negative. Just for Projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👾
Links to Jira Tickets
Description of Changes