Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIMSBIOHUB-442: Add support for hiding/showing table columns for Obserations and Telemetry #1198

Merged
merged 12 commits into from
Jan 26, 2024
Merged

SIMSBIOHUB-442: Add support for hiding/showing table columns for Obserations and Telemetry #1198

merged 12 commits into from
Jan 26, 2024

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Jan 18, 2024 •
edited
Loading

Links to Jira Tickets

Description of Changes

  • Add support for hiding/showing table columns for Obserations and Telemetry
  • Added sessionStorage call in order to cache column visibility across app reloads
  • Renamed ObservationComponent and ManualTelemetryComponent to ObservationsTableContainer and ManualTelemetryTableContainer

Testing Notes

  • Visit the Manage Observations or Manage Telemetry page
  • Click the cog icon
  • You should be able to:
    • Show/hide all columns
    • Show/hide additional columns
  • Show/hide some or all columns, then refresh the page. You should:
    • See that the visiblity state has persisted across refreshes

@curtisupshall curtisupshall added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Jan 18, 2024
@github-actions GitHub Actions
Copy link

Openshift URLs for the PR Deployment:

@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024 •
edited
Loading

Codecov Report

Attention: 100 lines in your changes are missing coverage. Please review.

Comparison is base (6e2b65b) 57.65% compared to head (b3e0178) 57.38%.

Files Patch % Lines
.../telemetry-table/ManualTelemetryTableContainer.tsx 0.00% 43 Missing ⚠️
.../observations-table/ObservationsTableContainer.tsx 0.00% 42 Missing ⚠️
app/src/contexts/observationsTableContext.tsx 0.00% 5 Missing ⚠️
...c/components/data-grid/DataGridValidationAlert.tsx 0.00% 4 Missing ⚠️
app/src/contexts/telemetryTableContext.tsx 0.00% 4 Missing ⚠️
...res/surveys/observations/SurveyObservationPage.tsx 0.00% 1 Missing ⚠️
...ervations/observations-table/ObservationsTable.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1198      +/-   ##
==========================================
- Coverage   57.65%   57.38%   -0.28%     
==========================================
  Files         582      582              
  Lines       17711    17795      +84     
  Branches     2720     2735      +15     
==========================================
  Hits        10212    10212              
- Misses       6839     6923      +84     
  Partials      660      660

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curtisupshall curtisupshall changed the title SIMSBIOHUB-442 SIMSBIOHUB-442: Add support for hiding/showing table columns for Obserations and Telemetry Jan 19, 2024
@curtisupshall curtisupshall added Ready For Review PR is ready for review and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Jan 24, 2024
@curtisupshall curtisupshall marked this pull request as ready for review January 24, 2024 18:24
@github-actions GitHub Actions
Copy link

Openshift URLs for the PR Deployment:

@NickPhura NickPhura self-assigned this Jan 24, 2024
@NickPhura

This comment was marked as resolved.

Sign in to view
al-rosenthal

This comment was marked as resolved.

Sign in to view

@al-rosenthal al-rosenthal dismissed their stale review January 25, 2024 18:57

further testing revealed this PR isn't ready

NickPhura
NickPhura previously approved these changes Jan 26, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

31.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

al-rosenthal
al-rosenthal approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran this locally and it works as expected 🔧

NickPhura
NickPhura approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌔

@curtisupshall curtisupshall merged commit 8f4d09d into dev Jan 26, 2024
16 of 19 checks passed
@curtisupshall curtisupshall deleted the SIMSBIOHUB-442 branch January 26, 2024 19:59
KjartanE pushed a commit that referenced this pull request Feb 1, 2024
@curtisupshall @KjartanE
SIMSBIOHUB-442: Add support for hiding/showing table columns for Obse…
b927479 
…rations and Telemetry (#1198)

* Add support for hiding/showing table columns for Obserations and Telemetry
* Added sessionStorage call in order to cache column visibility across app reloads
* Renamed ObservationComponent and ManualTelemetryComponent to ObservationsTableContainer and ManualTelemetryTableContainer, respectively
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@al-rosenthal al-rosenthal al-rosenthal approved these changes

@NickPhura NickPhura NickPhura approved these changes

@KjartanE KjartanE Awaiting requested review from KjartanE

@MacQSL MacQSL Awaiting requested review from MacQSL

Assignees

@NickPhura NickPhura

Labels
Ready For Review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curtisupshall @NickPhura @al-rosenthal