Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Updates #1205

Merged
merged 7 commits into from
Jan 30, 2024
Merged

UI Updates #1205

merged 7 commits into from
Jan 30, 2024

Conversation

jeznorth
Copy link
Contributor

Description of Changes

  • Address technical debt for disparate header components across the application

@jeznorth jeznorth requested a review from KjartanE January 29, 2024 18:08
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (8f4d09d) 57.38% compared to head (e114826) 57.37%.

Files Patch % Lines
app/src/components/loading/SkeletonLoaders.tsx 0.00% 8 Missing ⚠️
app/src/features/projects/view/ProjectHeader.tsx 0.00% 5 Missing ⚠️
...rojects/participants/ProjectParticipantsHeader.tsx 0.00% 2 Missing ⚠️
...res/surveys/observations/SurveyObservationPage.tsx 0.00% 2 Missing ⚠️
...features/surveys/telemetry/ManualTelemetryPage.tsx 0.00% 2 Missing ⚠️
...es/funding-sources/list/FundingSourcesListPage.tsx 0.00% 1 Missing ⚠️
...src/features/projects/create/CreateProjectPage.tsx 0.00% 1 Missing ⚠️
app/src/features/projects/edit/EditProjectPage.tsx 0.00% 1 Missing ⚠️
...s/surveys/observations/SurveyObservationHeader.tsx 0.00% 1 Missing ⚠️
...atures/surveys/telemetry/ManualTelemetryHeader.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1205      +/-   ##
==========================================
- Coverage   57.38%   57.37%   -0.02%     
==========================================
  Files         582      583       +1     
  Lines       17795    17799       +4     
  Branches     2735     2734       -1     
==========================================
  Hits        10212    10212              
- Misses       6923     6927       +4     
  Partials      660      660              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

curtisupshall
curtisupshall previously approved these changes Jan 29, 2024
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me 💅

@jeznorth jeznorth requested a review from NickPhura January 29, 2024 22:16
Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐱 Looks good, tested locally

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jeznorth jeznorth merged commit 0db6238 into dev Jan 30, 2024
17 of 19 checks passed
@NickPhura NickPhura deleted the UI-Updates branch January 30, 2024 17:22
KjartanE pushed a commit that referenced this pull request Feb 1, 2024
* Adding PageHeader component to all relevant pages

* Small Layout Fix

* Fixing test

* Remove uuid call from SkeletonLoaders.tsx

* Lint fixes.

* ignore-skip

---------

Co-authored-by: Curtis Upshall <[email protected]>
Co-authored-by: Nick Phura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants