Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-414: Show Feature Popup on Survey Page #1206

Merged
merged 21 commits into from
Feb 7, 2024
Merged

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Feb 1, 2024

Links to Jira Tickets

Description of Changes

Testing Notes

  • See Figma for appropriate popup styling/metadata.

@curtisupshall curtisupshall added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 70 lines in your changes are missing coverage. Please review.

Comparison is base (6118b56) 56.98% compared to head (2bfd97c) 56.88%.

Files Patch % Lines
app/src/features/surveys/view/SurveyMap.tsx 6.66% 28 Missing ⚠️
...view/components/spatial-data/SurveySpatialData.tsx 0.00% 27 Missing ⚠️
app/src/hooks/useTelemetryApi.ts 0.00% 12 Missing ⚠️
...features/surveys/telemetry/ManualTelemetryList.tsx 0.00% 2 Missing ⚠️
app/src/contexts/telemetryDataContext.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1206      +/-   ##
==========================================
- Coverage   56.98%   56.88%   -0.10%     
==========================================
  Files         594      594              
  Lines       17983    18018      +35     
  Branches     2768     2776       +8     
==========================================
+ Hits        10247    10249       +2     
- Misses       7070     7103      +33     
  Partials      666      666              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curtisupshall curtisupshall added Ready For Review PR is ready for review and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Feb 3, 2024
@curtisupshall curtisupshall marked this pull request as ready for review February 5, 2024 18:28
@curtisupshall curtisupshall requested a review from MacQSL February 5, 2024 23:53
al-rosenthal
al-rosenthal previously approved these changes Feb 6, 2024
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran this locally, looks and runs well! 📈

Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍿

@curtisupshall curtisupshall merged commit e69be82 into dev Feb 7, 2024
17 of 19 checks passed
@curtisupshall curtisupshall deleted the SIMSBIOHUB-414 branch February 7, 2024 18:56
curtisupshall added a commit that referenced this pull request Feb 7, 2024
* Adds survey sampling sites and study areas back to the Survey Map (since being removed by #1202);
* Adds various popups to survey map features, showing various point/polygon metadata;
* Removes extraneous observation table hook call;
* Updates method names and documentation for telemetry API hooks.
KjartanE pushed a commit that referenced this pull request Feb 8, 2024
* Adds survey sampling sites and study areas back to the Survey Map (since being removed by #1202);
* Adds various popups to survey map features, showing various point/polygon metadata;
* Removes extraneous observation table hook call;
* Updates method names and documentation for telemetry API hooks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants