421 - BCTW Multiple Device Fix

[MacQSL]

Links to Jira Tickets

• SIMSBIOHUB-421

Description of Changes

• Multiple devices can be created using the same device_id for critters (with different device makes)

Testing Notes

• Add a critter
• Add a deployment using a device id and a device make
• Add another deployment with same device id and different device make (should succeed)
• Add another deployment with same device id and same device make (should fail)

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1208-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1208-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1208

[codecov]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (08bcecc) 56.89% compared to head (9a61266) 56.90%.

Files	Patch %	Lines
...y-animals/telemetry-device/TelemetryDeviceForm.tsx	0.00%	2 Missing ⚠️
...ls/telemetry-device/TelemetryDeviceFormContent.tsx	0.00%	2 Missing ⚠️
...features/surveys/telemetry/ManualTelemetryList.tsx	0.00%	1 Missing ⚠️
...ures/surveys/view/survey-animals/AddEditAnimal.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##              dev    #1208   +/-   ##
=======================================
  Coverage   56.89%   56.90%           
=======================================
  Files         594      594           
  Lines       18014    18011    -3     
  Branches     2775     2774    -1     
=======================================
  Hits        10249    10249           
+ Misses       7099     7096    -3     
  Partials      666      666           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[al-rosenthal]

I ran this locally and was able to add multiple device makes as you'd expect. When I tried with data that should 'fail' I noticed that the date inputs gave warnings of the same device make within the date range and could not save. Is this what you meant by 'fail'?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[curtisupshall]

LGTM

[al-rosenthal]

tried this out and works as expected 🍰