-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMSBIOHUB-483: Paginate the Projects lists endpoint #1212
Conversation
… and project supplementary data.
…Create Project page
Openshift URLs for the PR Deployment: |
…mmon pagination API schema)
…d typing to accomodate pagination
Openshift URLs for the PR Deployment: |
8438e79
to
6debdcc
Compare
Looks good. The project advanced filters are a bit messed up though (partially related to pagination, but also related to other changes we've made recently, like the taxon changes). But maybe we should handle that as part of a different ticket. We probably need to run it by Jeremy first, to see what filters are even relevant still, etc. |
Quality Gate passedIssues Measures |
Good call. I've opened a ticket to get the conversation started. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ran this locally and it works as expected 🍰
* Added new environment variables used to the set number of seed projects and surveys to generate: NUM_SEED_PROJECTS and NUM_SEED_SURVEYS_PER_PROJECT. * Removed frontend code associated with creating, editing and deleting project drafts. * Optimized SQL queries used to fetch the projects list * Removed the project submission status from the projects list response * Removed the project submission status banner * Modified the list projects endpoint to support server-side pagination
Overview
Paginates the projects list table, removes dead code, and optimizes code associated with projects.
Links to Jira Tickets
Description of Changes
NUM_SEED_PROJECTS
NUM_SEED_SURVEYS_PER_PROJECT
Testing Notes
You should be able to: