Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-461: "Missing Field" snackbar fix #1215

Merged
merged 9 commits into from
Feb 21, 2024
Merged

SIMSBIOHUB-461: "Missing Field" snackbar fix #1215

merged 9 commits into from
Feb 21, 2024

Conversation

KjartanE
Copy link
Contributor

Links to Jira Tickets

Description of Changes

  • Remove Scroll to error feature
  • Remove extra snackbar message when form is submitted successfully
  • Remove bug when snackbar shows before submission

Testing Notes

  • Create/Edit on both Project and Survey pages

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (493e17b) 56.64% compared to head (d710d1a) 56.67%.

Files Patch % Lines
app/src/components/alert/FormikErrorSnackbar.tsx 66.66% 3 Missing and 1 partial ⚠️
...p/src/components/species/FocalSpeciesComponent.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1215      +/-   ##
==========================================
+ Coverage   56.64%   56.67%   +0.02%     
==========================================
  Files         587      587              
  Lines       17849    17825      -24     
  Branches     2769     2763       -6     
==========================================
- Hits        10111    10102       -9     
+ Misses       7068     7053      -15     
  Partials      670      670              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Openshift, seems to work as expected. ✅

@curtisupshall curtisupshall added the Ready For Review PR is ready for review label Feb 21, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧷

@KjartanE KjartanE merged commit 95e86f6 into dev Feb 21, 2024
18 of 19 checks passed
@KjartanE KjartanE deleted the SIMSBIOHUB-461 branch February 21, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants