Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-487: Collaborators and Coordinators Auth Guard #1218

Merged
merged 11 commits into from
Feb 23, 2024
Merged

Conversation

KjartanE
Copy link
Contributor

@KjartanE KjartanE commented Feb 21, 2024

Links to Jira Tickets

Description of Changes

  • Roll guard the following functionality on the Survey Page:

    • Survey Edit
    • Manage Observations and Telemetry
    • Manage Marked and Known Animals
    • Marked and Known Animals Context Menu for each record
    • Document Upload
    • Context Menu for Documents (guard delete functionality)
    • Survey Details Component
  • Prevent access to following pages (403 error)

    • Manage Observations
    • Manage Telemetry
    • Manage Animals
    • Create Survey
    • Edit Survey
  • Roll guard the following functionality on the Project Page

    • Settings
    • Create Survey
    • Upload Documents
    • Context Menu for Documents (guard delete functionality)
  • Prevent access to the following pages (403 error)

    • Edit Project
    • Manage Project Team
  • Roll guard the following functionality on the Project List Page

    • Create Project
  • Prevent access the following pages (403 error)

    • Create Project Page

Testing Notes

  • Test all referenced pages and components for individual authentication levels
    • system admin - can do everything
    • data admin - can do everything except manage system users
    • project coordinator - can do everything under a project
    • project collaborator - can do everything under a project except manage project users, delete a project/survey, publish a survey
    • project observer - can do nothing

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 56.69%. Comparing base (95e86f6) to head (b4c5efc).

Files Patch % Lines
...rc/components/attachments/list/AttachmentsList.tsx 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1218      +/-   ##
==========================================
+ Coverage   56.67%   56.69%   +0.02%     
==========================================
  Files         587      587              
  Lines       17825    17823       -2     
  Branches     2763     2762       -1     
==========================================
+ Hits        10102    10105       +3     
+ Misses       7053     7048       -5     
  Partials      670      670              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried testing this out as an full admin and I tried to create a project but was met with a state error around the codes context provider.

@KjartanE
Copy link
Contributor Author

I tried testing this out as an full admin and I tried to create a project but was met with a state error around the codes context provider.

Seemed to be a merged issue, resolved the bug.

NickPhura
NickPhura previously approved these changes Feb 23, 2024
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒

Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥡

@KjartanE KjartanE merged commit e1254d7 into dev Feb 23, 2024
19 checks passed
@KjartanE KjartanE deleted the SIMSBIOHUB-487 branch February 23, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants