Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Cleanup #1222

Merged
merged 11 commits into from
Feb 29, 2024
Merged

UI Cleanup #1222

merged 11 commits into from
Feb 29, 2024

Conversation

jeznorth
Copy link
Contributor

Description of Changes

  • Various changes to front-end to clean up disparate patterns and UI elements.

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 56.36%. Comparing base (ce90f56) to head (c3eb50d).

Files Patch % Lines
app/src/components/publish/PublishSurveyDialog.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1222      +/-   ##
==========================================
- Coverage   56.43%   56.36%   -0.08%     
==========================================
  Files         576      576              
  Lines       17626    17615      -11     
  Branches     2745     2746       +1     
==========================================
- Hits         9948     9929      -19     
- Misses       7014     7024      +10     
+ Partials      664      662       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me! Just had a couple minor comments

KjartanE
KjartanE previously approved these changes Feb 28, 2024
Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good!

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.9% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈

@KjartanE KjartanE merged commit acab56e into dev Feb 29, 2024
17 checks passed
@KjartanE KjartanE deleted the UI-Cleanup branch February 29, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants