Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add draw controls to the sample site map #1223

Merged
merged 8 commits into from
Feb 29, 2024
Merged

Add draw controls to the sample site map #1223

merged 8 commits into from
Feb 29, 2024

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Feb 28, 2024 •
edited
Loading

Links to Jira Tickets

  • N/A

Description of Changes

  • Added FeatureLayer and DrawControls to the Sample Site create and edit map

Testing Notes

  • Should be able to create and replace sampling site locations using drawing controls
  • Should be able to create points, lines, or polygons
  • You can only create one site per create request (can't draw multiple sites at once and bulk-create)

@github-actions GitHub Actions
Copy link

Openshift URLs for the PR Deployment:

@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Feb 28, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

KjartanE
KjartanE approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Draw control function properly

curtisupshall
curtisupshall approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works well 🗺️

@mauberti-bc mauberti-bc merged commit a7cdac3 into dev Feb 29, 2024
17 checks passed
@mauberti-bc mauberti-bc deleted the sample-site-draw-controls branch February 29, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KjartanE KjartanE KjartanE approved these changes

@curtisupshall curtisupshall curtisupshall approved these changes

@al-rosenthal al-rosenthal Awaiting requested review from al-rosenthal

@NickPhura NickPhura Awaiting requested review from NickPhura

Assignees
No one assigned
Labels
Ready For Review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mauberti-bc @curtisupshall @KjartanE