Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-519: Event schema #1229

Merged
merged 9 commits into from
Mar 5, 2024
Merged

SIMSBIOHUB-519: Event schema #1229

merged 9 commits into from
Mar 5, 2024

Conversation

al-rosenthal
Copy link
Contributor

Links to Jira Tickets

SIMSBIOHUB-519

Description of Changes

  • added new migration to support SIMS holding event architecture
  • migration based off of discussion surrounding this miro board

Testing Notes

  • all migrations should run successfully
  • subcount_event table and view should be removed

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.35%. Comparing base (c96c865) to head (be42f6f).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1229   +/-   ##
=======================================
  Coverage   55.35%   55.35%           
=======================================
  Files         592      592           
  Lines       17985    17985           
  Branches     2772     2772           
=======================================
  Hits         9956     9956           
  Misses       7368     7368           
  Partials      661      661           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickPhura
Copy link
Collaborator

@al-rosenthal Don't forget to add the views for the new tables

@al-rosenthal al-rosenthal requested a review from NickPhura March 5, 2024 17:47
@al-rosenthal al-rosenthal marked this pull request as ready for review March 5, 2024 19:42
NickPhura
NickPhura previously approved these changes Mar 5, 2024
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟦

Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈

@al-rosenthal al-rosenthal merged commit 7e103a2 into dev Mar 5, 2024
17 checks passed
@al-rosenthal al-rosenthal deleted the SIMSBIOHUB-519 branch March 5, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants