Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: create the database procedures folder #1233

Merged
merged 19 commits into from
Mar 11, 2024
Merged

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Mar 6, 2024

Description of Changes

  • Moves the PGSQL stored procedures from migrations to a dedicated seed folder.
  • Updates the database README file
  • Removes unused Dockerfiles

Testing Notes

You should be able to

  • Delete a survey
  • Delete a project

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 55.12%. Comparing base (a820024) to head (6c0f2d5).

Files Patch % Lines
app/src/features/projects/view/ProjectHeader.tsx 0.00% 1 Missing ⚠️
app/src/features/surveys/view/SurveyHeader.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1233   +/-   ##
=======================================
  Coverage   55.12%   55.12%           
=======================================
  Files         603      603           
  Lines       18293    18293           
  Branches     2817     2817           
=======================================
  Hits        10084    10084           
  Misses       7542     7542           
  Partials      667      667           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curtisupshall curtisupshall requested a review from NickPhura March 7, 2024 00:21
@curtisupshall curtisupshall added the Ready For Review PR is ready for review label Mar 7, 2024
@curtisupshall curtisupshall marked this pull request as ready for review March 7, 2024 17:31
al-rosenthal

This comment was marked as resolved.

al-rosenthal
al-rosenthal previously approved these changes Mar 8, 2024
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran this locally and it looks good! 🍦

NickPhura
NickPhura previously approved these changes Mar 8, 2024
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗡️

@curtisupshall curtisupshall dismissed stale reviews from NickPhura and al-rosenthal via 5ad754d March 8, 2024 18:18
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧥 🗡️

@al-rosenthal al-rosenthal merged commit b005469 into dev Mar 11, 2024
17 checks passed
@al-rosenthal al-rosenthal deleted the delete-procedure branch March 11, 2024 20:56
KjartanE pushed a commit that referenced this pull request Mar 11, 2024
SIMSBIOHUB-TechDebt: Project/ Survey delete procedure can now be updated without a migration. Misc text changes/ UI updates

---------

Co-authored-by: Nick Phura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants