Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIMSBIOHUB-492: Fix project advanced filters #1235

Merged
merged 17 commits into from
Mar 12, 2024
Merged

SIMSBIOHUB-492: Fix project advanced filters #1235

merged 17 commits into from
Mar 12, 2024

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Mar 8, 2024 •
edited
Loading

Links to Jira Tickets

Description of Changes

  • Fixes the projects list advanced filters to support:
    • Paginated results with advanced filters applied, and;
    • ITIS TSN searching.
  • Added support to search on multiple species;
  • Used MUI Collapse to show/hide advanced filters form;
  • Code cleanup, minor tech debt.

Testing Notes

You should change NUM_SEED_PROJECTS in your .env file to make testing easier.

  • You should be able to filter projects on any and all of the advanced filter fields
  • Pagination should work on advanced-filtered results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

Openshift URLs for the PR Deployment:

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 55.26%. Comparing base (b005469) to head (815e6c7).

Files Patch % Lines
api/src/repositories/project-repository.ts 73.33% 6 Missing and 2 partials ⚠️
api/src/paths/project/list.ts 25.00% 0 Missing and 6 partials ⚠️
...pp/src/features/projects/list/ProjectsListPage.tsx 66.66% 2 Missing and 1 partial ⚠️
...omponents/search-filter/ProjectAdvancedFilters.tsx 50.00% 1 Missing and 1 partial ⚠️
app/src/hooks/useContext.tsx 60.00% 1 Missing and 1 partial ⚠️
app/src/components/dialog/SubmitBiohubDialog.tsx 0.00% 1 Missing ⚠️
...ents/dialog/attachments/EditFileWithMetaDialog.tsx 0.00% 1 Missing ⚠️
.../features/projects/list/ProjectsListFilterForm.tsx 50.00% 1 Missing ⚠️
app/src/features/surveys/edit/EditSurveyPage.tsx 0.00% 1 Missing ⚠️
...s/observations/sampling-sites/SamplingSitePage.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1235      +/-   ##
==========================================
+ Coverage   55.12%   55.26%   +0.13%     
==========================================
  Files         603      603              
  Lines       18293    18285       -8     
  Branches     2817     2815       -2     
==========================================
+ Hits        10084    10105      +21     
+ Misses       7542     7513      -29     
  Partials      667      667

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curtisupshall curtisupshall added the Ready For Review PR is ready for review label Mar 11, 2024
@curtisupshall curtisupshall marked this pull request as ready for review March 11, 2024 21:44
@github-actions GitHub Actions
Copy link

Openshift URLs for the PR Deployment:

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@curtisupshall curtisupshall requested a review from NickPhura March 12, 2024 18:38
NickPhura
NickPhura approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍

al-rosenthal
al-rosenthal approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran this locally and things looks good

@curtisupshall curtisupshall merged commit 032c623 into dev Mar 12, 2024
17 checks passed
@curtisupshall curtisupshall deleted the SIMSBIOHUB-492 branch March 12, 2024 19:11
KjartanE pushed a commit that referenced this pull request Mar 13, 2024
@curtisupshall @KjartanE
SIMSBIOHUB-492: Fix project advanced filters (#1235)
9dbc452 
* Fixes the projects list advanced filters to support paginated results with advanced filters applied and ITIS TSN searching.
* Added support to search on multiple species.
* Used MUI Collapse to show/hide advanced filters form.
* Code cleanup, minor tech debt.
mauberti-bc added a commit that referenced this pull request Apr 8, 2024
@mauberti-bc
SIMSBIOHUB-492: Fix project advanced filters (#1235)
c26af5f 
* Fixes the projects list advanced filters to support paginated results with advanced filters applied and ITIS TSN searching.
* Added support to search on multiple species.
* Used MUI Collapse to show/hide advanced filters form.
* Code cleanup, minor tech debt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@al-rosenthal al-rosenthal al-rosenthal approved these changes

@NickPhura NickPhura NickPhura approved these changes

@KjartanE KjartanE Awaiting requested review from KjartanE

@MacQSL MacQSL Awaiting requested review from MacQSL

Assignees
No one assigned
Labels
Ready For Review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@curtisupshall @codecov-commenter @NickPhura @al-rosenthal