Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front-end Clean-up #1239

Merged
merged 11 commits into from
Mar 13, 2024
Merged

Front-end Clean-up #1239

merged 11 commits into from
Mar 13, 2024

Conversation

jeznorth
Copy link
Contributor

@jeznorth jeznorth commented Mar 12, 2024

Links to Jira Tickets

(https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-479)](https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-479)

Description of Changes

  • General front-end clean-up. Standardizing layout patterns.

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 43.88379% with 367 lines in your changes are missing coverage. Please review.

Project coverage is 55.12%. Comparing base (d2a1c85) to head (305f64e).
Report is 11 commits behind head on dev.

❗ Current head 305f64e differs from pull request most recent head 981d63a. Consider uploading reports for the commit 981d63a to get more accurate results

Files Patch % Lines
...ns/sampling-sites/components/SamplingBlockForm.tsx 0.00% 28 Missing ⚠️
...ng-sites/edit/components/SamplingBlockEditForm.tsx 0.00% 28 Missing ⚠️
...-sites/edit/components/SamplingStratumEditForm.tsx 0.00% 28 Missing ⚠️
.../sampling-sites/components/SamplingStratumForm.tsx 0.00% 26 Missing ⚠️
app/src/features/projects/edit/EditProjectPage.tsx 0.00% 18 Missing ⚠️
app/src/features/surveys/edit/EditSurveyForm.tsx 5.26% 18 Missing ⚠️
...src/features/projects/create/CreateProjectPage.tsx 36.84% 11 Missing and 1 partial ⚠️
.../features/surveys/components/SurveyStratumForm.tsx 8.33% 11 Missing ⚠️
api/src/repositories/observation-repository.ts 16.66% 9 Missing and 1 partial ⚠️
api/src/repositories/sample-stratums-repository.ts 71.42% 10 Missing ⚠️
... and 57 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1239      +/-   ##
==========================================
- Coverage   55.28%   55.12%   -0.17%     
==========================================
  Files         593      603      +10     
  Lines       18016    18285     +269     
  Branches     2771     2816      +45     
==========================================
+ Hits         9960    10079     +119     
- Misses       7398     7539     +141     
- Partials      658      667       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeznorth jeznorth requested review from curtisupshall and al-rosenthal and removed request for curtisupshall March 12, 2024 18:05
curtisupshall
curtisupshall previously approved these changes Mar 12, 2024
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
10.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@jeznorth jeznorth requested a review from NickPhura March 13, 2024 15:59
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥡

@jeznorth jeznorth merged commit ce20bbb into dev Mar 13, 2024
16 of 17 checks passed
KjartanE pushed a commit that referenced this pull request Mar 13, 2024
Front-end clean-up on the following interfaces:

* Taxonomy Displays
* Project team members list (autocomplete)
* Project List Page filters
* General Layout Updates / Formatting

---------

Co-authored-by: Nick Phura <[email protected]>
Co-authored-by: Alfred Rosenthal <[email protected]>
@jeznorth jeznorth deleted the UI-Cleanup branch March 19, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants