Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-533: Migrate MUI Table to MUI DataGrid for Attachments List and Manage Users #1241

Merged
merged 10 commits into from
Mar 15, 2024

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Mar 13, 2024

Links to Jira Tickets

Description of Changes

  • Adds MUI DataGrid to AttachmentsList.
  • Adds MUI DataGrid to Active Users list on the Manage Users page.
  • Adds MUI DataGrid to Access Requests list on the Manage Users page.

Testing Notes

  • You should be able to see multiple pages of users, access requests, and attachments (for surveys and projects).
  • You should be able to sort the access requests table, active users table, and attachments list (for surveys and projects).

@curtisupshall curtisupshall added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Mar 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 54.56%. Comparing base (cb26206) to head (af3446f).

Files Patch % Lines
...rc/components/attachments/list/AttachmentsList.tsx 70.00% 3 Missing and 3 partials ⚠️
app/src/features/admin/users/AccessRequestList.tsx 79.16% 3 Missing and 2 partials ⚠️
app/src/features/admin/users/ActiveUsersList.tsx 73.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1241      +/-   ##
==========================================
+ Coverage   54.54%   54.56%   +0.01%     
==========================================
  Files         599      599              
  Lines       18376    18392      +16     
  Branches     2837     2837              
==========================================
+ Hits        10024    10035      +11     
- Misses       7701     7703       +2     
- Partials      651      654       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curtisupshall curtisupshall added the Ready For Review PR is ready for review label Mar 14, 2024
@curtisupshall curtisupshall marked this pull request as ready for review March 14, 2024 22:32
@curtisupshall curtisupshall removed the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Mar 14, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚜

@NickPhura NickPhura merged commit 0daa88d into dev Mar 15, 2024
17 checks passed
@NickPhura NickPhura deleted the SIMSBIOHUB-533 branch March 15, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants