-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMSBIOHUB-530: Unique Key Constraint on Survey Funding Source #1244
Conversation
Openshift URLs for the PR Deployment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ran this locally and it works. It would be great if the funding sources were also highlighted in red, the error text is easy to miss if you have to scroll through the form to find the issue
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1244 +/- ##
==========================================
- Coverage 54.56% 54.54% -0.02%
==========================================
Files 599 599
Lines 18392 18401 +9
Branches 2837 2839 +2
==========================================
+ Hits 10035 10037 +2
- Misses 7703 7710 +7
Partials 654 654 ☔ View full report in Codecov by Sentry. |
Agreed. Though it looks like this matches the current behaviour of permits (which has the same unique constraint), so maybe something we can leave for a future ticket |
Quality Gate passedIssues Measures |
Links to Jira Tickets
Description of Changes
Testing Notes