Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-500/140: Purge Old SIMS Code #1249

Merged
merged 6 commits into from
Mar 19, 2024
Merged

SIMSBIOHUB-500/140: Purge Old SIMS Code #1249

merged 6 commits into from
Mar 19, 2024

Conversation

KjartanE
Copy link
Contributor

Links to Jira Tickets

Description of Changes

  • Remove any unused code
  • Clean out old snapshot tests

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

@KjartanE KjartanE marked this pull request as ready for review March 19, 2024 18:37
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.82%. Comparing base (2500bac) to head (a7a8920).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1249      +/-   ##
==========================================
+ Coverage   52.37%   52.82%   +0.44%     
==========================================
  Files         578      561      -17     
  Lines       17216    16981     -235     
  Branches     2678     2631      -47     
==========================================
- Hits         9017     8970      -47     
+ Misses       7592     7405     -187     
+ Partials      607      606       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KjartanE KjartanE added the Ready For Review PR is ready for review label Mar 19, 2024
@curtisupshall curtisupshall self-assigned this Mar 19, 2024
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👛

Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@NickPhura NickPhura merged commit 8df78ed into dev Mar 19, 2024
17 checks passed
@NickPhura NickPhura deleted the SIMSBIOHUB-500 branch March 19, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants