Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage #1265

Merged
merged 10 commits into from
Apr 2, 2024
Merged

Test coverage #1265

merged 10 commits into from
Apr 2, 2024

Conversation

al-rosenthal
Copy link
Contributor

@al-rosenthal al-rosenthal commented Mar 28, 2024

Description of Changes

  • Added test coverage to:
    • measurement validation in work sheet utils
    • observation subcount service and repository

@al-rosenthal al-rosenthal marked this pull request as ready for review March 28, 2024 18:27
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.32%. Comparing base (91b1165) to head (21bffa0).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1265      +/-   ##
==========================================
+ Coverage   52.89%   53.32%   +0.43%     
==========================================
  Files         549      549              
  Lines       16236    16237       +1     
  Branches     2524     2524              
==========================================
+ Hits         8588     8659      +71     
+ Misses       7072     6999      -73     
- Partials      576      579       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KjartanE
KjartanE previously approved these changes Mar 28, 2024
Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈 all tests passing

@curtisupshall curtisupshall self-assigned this Mar 28, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@curtisupshall curtisupshall merged commit 42b936b into dev Apr 2, 2024
17 checks passed
@curtisupshall curtisupshall deleted the TestCoverage branch April 2, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants