Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-566: Update to Node 18 #1266

Merged
merged 17 commits into from
Apr 8, 2024
Merged

SIMSBIOHUB-566: Update to Node 18 #1266

merged 17 commits into from
Apr 8, 2024

Conversation

NickPhura
Copy link
Collaborator

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-566

Description of Changes

Update Node from version 14 to version 18.

Testing Notes

Builds/deploys as normal.

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 53.25%. Comparing base (42b936b) to head (b5520cd).

Files Patch % Lines
...ies/observation-subcount-measurement-repository.ts 0.00% 4 Missing ⚠️
...omponents/SampleSiteFileUploadItemActionButton.tsx 0.00% 4 Missing ⚠️
...repositories/site-selection-strategy-repository.ts 0.00% 0 Missing and 3 partials ⚠️
...ponents/publish/components/AttachmentsFileCard.tsx 25.00% 3 Missing ⚠️
...components/SampleSiteFileUploadItemProgressBar.tsx 0.00% 3 Missing ⚠️
api/src/repositories/observation-repository.ts 0.00% 1 Missing and 1 partial ⚠️
api/src/repositories/survey-repository.ts 33.33% 0 Missing and 2 partials ⚠️
app/src/components/attachments/ReportMeta.tsx 33.33% 2 Missing ⚠️
...nts/dialog/attachments/ReportAttachmentDetails.tsx 33.33% 2 Missing ⚠️
...-sources/details/FundingSourceSurveyReferences.tsx 50.00% 2 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1266      +/-   ##
==========================================
- Coverage   53.32%   53.25%   -0.08%     
==========================================
  Files         549      547       -2     
  Lines       16237    16231       -6     
  Branches     2524     2517       -7     
==========================================
- Hits         8659     8644      -15     
- Misses       6999     7007       +8     
- Partials      579      580       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickPhura NickPhura requested a review from MacQSL April 3, 2024 23:41
@NickPhura NickPhura force-pushed the SIMSBIOHUB-566-2 branch 7 times, most recently from c22be6a to 792cde1 Compare April 4, 2024 06:58
@NickPhura NickPhura added the Ready For Review PR is ready for review label Apr 5, 2024
Copy link

sonarqubecloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickPhura NickPhura merged commit c52684a into dev Apr 8, 2024
17 checks passed
@NickPhura NickPhura deleted the SIMSBIOHUB-566-2 branch April 8, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants