-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BHBC-866: Date improvements #134
Conversation
Knock Knock! 🔍 Just thought I'd let you know that your PR title and story title look quite different. PR titles that closely resemble the story title make it easier for reviewers to understand the context of the PR. An easy-to-understand PR title a day makes the reviewer review away! 😛⚡️
Check out this guide to learn more about PR best-practices. |
Codecov Report
@@ Coverage Diff @@
## dev #134 +/- ##
==========================================
+ Coverage 42.16% 42.21% +0.04%
==========================================
Files 93 94 +1
Lines 1909 1921 +12
Branches 428 429 +1
==========================================
+ Hits 805 811 +6
- Misses 1030 1036 +6
Partials 74 74
Continue to review full report at Codecov.
|
💔 The detected issue is not in one of the allowed statuses 💔
Please ensure your jira story is in one of the allowed statuses |
💔 The detected issue is not in one of the allowed statuses 💔
Please ensure your jira story is in one of the allowed statuses |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome :)
Overview
Links to jira tickets
https://quartech.atlassian.net/browse/BHBC-866
Deployed app: https://biohubbc-app-134-af2668-dev.apps.silver.devops.gov.bc.ca/projects
This PR contains the following changes
Improvements to date pickers.
In chrome the year should be limited to 4 digits, firefox it still allows 6.
Added better validation so now it will error if the date is invalid (ie: if you enter 6 digits for the year in firefox)
Includes an initial pass at some re-usable yup schemas.
Added a handful of max string length checks, so we should get less errors when people enter long project names, etc.
This PR contains the following types of changes
Checklist
A list of items that are good to consider when making any changes.
Note: this list is not exhaustive, and not all items are always applicable.
General
Code
Style
Documentation
Tests
Linting/Formatting
See the
lint
commands in package.jsonSee the
format
commands in package.jsonSonarCloud
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Screenshots
Please add any relevant UI screenshots, if applicable.