-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and clean up code duplication #140
Conversation
A JIRA Issue ID is missing from your branch name! 🦄 Your branch: sd-cleanup-reused-code If this is your first time contributing to this repository - welcome! Please refer to jira-lint to get started. Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail. Valid sample branch names:‣ feature/shiny-new-feature--mojo-10' |
Codecov Report
@@ Coverage Diff @@
## dev #140 +/- ##
==========================================
+ Coverage 42.62% 42.70% +0.07%
==========================================
Files 95 97 +2
Lines 1933 1932 -1
Branches 435 435
==========================================
+ Hits 824 825 +1
+ Misses 1038 1036 -2
Partials 71 71
Continue to review full report at Codecov.
|
A JIRA Issue ID is missing from your branch name! 🦄 Your branch: sd-cleanup-reused-code If this is your first time contributing to this repository - welcome! Please refer to jira-lint to get started. Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail. Valid sample branch names:‣ feature/shiny-new-feature--mojo-10' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice clean up :-)
A JIRA Issue ID is missing from your branch name! 🦄 Your branch: sd-cleanup-reused-code If this is your first time contributing to this repository - welcome! Please refer to jira-lint to get started. Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail. Valid sample branch names:‣ feature/shiny-new-feature--mojo-10' |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Can you add the |
Overview
Refactor and clean up code duplication
Tested
All unit tests still work as expected