Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and clean up code duplication #140

Merged
merged 3 commits into from
Mar 17, 2021
Merged

Conversation

sdevalapurkar
Copy link
Contributor

Overview

Refactor and clean up code duplication

Tested

All unit tests still work as expected

@github-actions
Copy link

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: sd-cleanup-reused-code

If this is your first time contributing to this repository - welcome!


Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #140 (7bd551d) into dev (1b2a3f1) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #140      +/-   ##
==========================================
+ Coverage   42.62%   42.70%   +0.07%     
==========================================
  Files          95       97       +2     
  Lines        1933     1932       -1     
  Branches      435      435              
==========================================
+ Hits          824      825       +1     
+ Misses       1038     1036       -2     
  Partials       71       71              
Impacted Files Coverage Δ
app/src/AppRouter.tsx 20.00% <ø> (ø)
app/src/components/layout/Header.tsx 100.00% <ø> (ø)
app/src/features/projects/ProjectsRouter.tsx 33.33% <ø> (ø)
app/src/test-helpers/projectCodes.ts 100.00% <100.00%> (ø)
app/src/test-helpers/projectWithDetailsData.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b2a3f1...7bd551d. Read the comment docs.

@github-actions
Copy link

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: sd-cleanup-reused-code

If this is your first time contributing to this repository - welcome!


Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

Copy link
Contributor

@anissa-agahchen anissa-agahchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice clean up :-)

@github-actions
Copy link

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: sd-cleanup-reused-code

If this is your first time contributing to this repository - welcome!


Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@NickPhura
Copy link
Collaborator

NickPhura commented Mar 17, 2021

Can you add the test-helpers folder to the exclusions/inclusions lists in .sonarcloud.properties

@NickPhura NickPhura merged commit bb4eb80 into dev Mar 17, 2021
@NickPhura NickPhura deleted the sd-cleanup-reused-code branch March 17, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants