Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IUCN Classification section to View Project page #141

Merged
merged 7 commits into from
Mar 18, 2021
Merged

Conversation

sdevalapurkar
Copy link
Contributor

@sdevalapurkar sdevalapurkar commented Mar 17, 2021

BHBC-903
Summary Implement IUCN Classification section to View Project page
Type Story Story
Status In Progress
Points N/A
Labels -

Overview

Links to jira tickets

This PR contains the following changes

  • Add in IUCN Classification section to the view project page

This PR contains the following types of changes

  • New feature (change which adds functionality)
  • Enhancement (improvements to existing functionality)

How Has This Been Tested?

  • Locally

Screenshots

Screenshot 2021-03-18 105336

Fix

fixed

@github-actions
Copy link

I'm a bot and I 👍 this PR title. 🤖

@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #141 (0865332) into dev (bb4eb80) will increase coverage by 0.44%.
The diff coverage is 76.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #141      +/-   ##
==========================================
+ Coverage   42.70%   43.14%   +0.44%     
==========================================
  Files          97       98       +1     
  Lines        1932     1956      +24     
  Branches      435      442       +7     
==========================================
+ Hits          825      844      +19     
- Misses       1036     1038       +2     
- Partials       71       74       +3     
Impacted Files Coverage Δ
api/src/paths/project/{projectId}.ts 0.00% <0.00%> (ø)
app/src/features/projects/view/ProjectDetails.tsx 100.00% <ø> (ø)
app/src/test-helpers/projectWithDetailsData.ts 100.00% <ø> (ø)
...es/projects/view/components/IUCNClassification.tsx 77.77% <77.77%> (ø)
api/src/models/project.ts 47.82% <83.33%> (+1.95%) ⬆️
api/src/queries/project-queries.ts 73.91% <100.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb4eb80...0865332. Read the comment docs.

NickPhura
NickPhura previously approved these changes Mar 18, 2021
@github-actions
Copy link

💔 The detected issue is not in one of the allowed statuses 💔

Detected Status Peer Review
Allowed Statuses In Progress ✔️

Please ensure your jira story is in one of the allowed statuses

@sdevalapurkar sdevalapurkar requested a review from NickPhura March 18, 2021 17:59
NickPhura
NickPhura previously approved these changes Mar 18, 2021
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Edit: There is a minor padding issue I notice. The horizontal lines go too far to the left/right. Likely a side effect of losing the default padding that comes with the grid tags. But, I dont think its worth fussing over. Jeremy can do all of the fine grain styling as he sees fit

@github-actions
Copy link

💔 The detected issue is not in one of the allowed statuses 💔

Detected Status Peer Review
Allowed Statuses In Progress ✔️

Please ensure your jira story is in one of the allowed statuses

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sdevalapurkar sdevalapurkar requested a review from NickPhura March 18, 2021 19:23
@sdevalapurkar
Copy link
Contributor Author

Looks good!

Edit: There is a minor padding issue I notice. The horizontal lines go too far to the left/right. Likely a side effect of losing the default padding that comes with the grid tags. But, I dont think its worth fussing over. Jeremy can do all of the fine grain styling as he sees fit

fixed :)

@NickPhura NickPhura merged commit 6865ae8 into dev Mar 18, 2021
@NickPhura NickPhura deleted the BHBC-903 branch March 18, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants