Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code smells fixes #143

Merged
merged 2 commits into from
Mar 18, 2021
Merged

Code smells fixes #143

merged 2 commits into from
Mar 18, 2021

Conversation

sdevalapurkar
Copy link
Contributor

Overview

Code smells fixes

@github-actions
Copy link

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: sd-code-smells-again

If this is your first time contributing to this repository - welcome!


Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

@sdevalapurkar sdevalapurkar requested review from NickPhura and anissa-agahchen and removed request for NickPhura March 18, 2021 20:48
@sdevalapurkar sdevalapurkar self-assigned this Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #143 (f9674c8) into dev (6865ae8) will decrease coverage by 0.07%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #143      +/-   ##
==========================================
- Coverage   43.14%   43.07%   -0.08%     
==========================================
  Files          98       97       -1     
  Lines        1956     1943      -13     
  Branches      442      442              
==========================================
- Hits          844      837       -7     
+ Misses       1038     1032       -6     
  Partials       74       74              
Impacted Files Coverage Δ
api/src/utils/code-utils.ts 0.00% <0.00%> (ø)
app/src/App.tsx 33.33% <ø> (ø)
.../src/rjsf/business-rules/customErrorTransformer.ts 0.00% <0.00%> (ø)
app/src/utils/KeycloakEventHandler.ts 5.00% <50.00%> (+0.23%) ⬆️
app/src/hooks/useBioHubApi.ts 42.55% <100.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6865ae8...f9674c8. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: sd-code-smells-again

If this is your first time contributing to this repository - welcome!


Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

@sdevalapurkar sdevalapurkar merged commit eef2de7 into dev Mar 18, 2021
@sdevalapurkar sdevalapurkar deleted the sd-code-smells-again branch March 18, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants