SIMSBIOHUB-656: Import CSV Markings #1451

MacQSL · 2024-12-11T21:17:29Z

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-656

Description of Changes

CSV import for Critter markings
New CSVErrors table for rendering validation errors

Testing Notes

http://localhost:7100/admin/projects/2/surveys/4/animals/captures

Should be able to import a markings CSV into SIMS
Critters and captures will need to be created before markings can be imported

…from params

app/src/utils/file-utils.ts

…ning onClick

api/src/services/import-services/marking/import-markings-service.ts

api/src/services/import-services/marking/marking-header-configs.ts

api/src/utils/csv-utils/csv-config-utils.ts

Minor tweak to csv error datagrid settings.

…ohubbc into SIMSBIOHUB-633-markings

sonarqubecloud · 2024-12-20T21:01:07Z

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

api/src/services/import-services/marking/marking-header-configs.ts

NickPhura

🦌 🦌

MacQSL added 30 commits October 28, 2024 14:43

chore: partially done structure for new csv import

fe045e6

feat: validate method

8c0cc12

chore: wip

8062962

feat: progress...

a999b2d

feat: added validators for cell values

79f488f

chore: moved files

853cfe1

feat: updated docs for types

a0c4f87

feat: created new critter strategy

cb0a7b9

chore: still working on strucutre for config

73a1f50

feat: updated helper functions for csv-utils

1cd7235

feat: updated import csv critters

c5d9b71

feat: added new config header util files

0dffc39

feat: added files for csv-header-config validation / setter functions

834934f

chore: updated tests for cell validators

08709c1

feat: updated some structure + moved validation logic into class

4e742e6

feat: moved some redundant params around + seperated CSVHeaderConfig …

110766d

…from params

fix: updated some functions in csv-config-validation

2b0469b

chore: tests for rorEachCSVCell

29c51b6

feat: updated error formatting to be in the parent

2427513

feat: partial PR comments

e1e563f

feat: PR comments + additional JSDocs

61aad38

feat: created type for cell setter and validator

410d0f4

feat: updated tests for CSVConfigUtils

eb2b8aa

feat: updated types in CSVConfigUtils

7807f4e

feat: updated getters in CSVConfigUtils

75374ca

chore: resolving broken tests

2e230fa

feat: updated tests

d0494f4

feat: added nested record class

1ae762d

feat: added tests for endpoint

7cc6f4a

fix: pr comments

32b4c89

MacQSL requested a review from mauberti-bc December 19, 2024 17:04

MacQSL added the Ready For Review PR is ready for review label Dec 19, 2024

chore: updated tests

eb00d42

MacQSL commented Dec 19, 2024

View reviewed changes

app/src/utils/file-utils.ts Outdated Show resolved Hide resolved

MacQSL added 4 commits December 19, 2024 12:01

fix: updated tests for markings

fdb4f04

fix: gridcoldef null value lowercase

101010a

fix: issue with undefined values bubbling up

db11a27

fix: broken test

32d13b2

MacQSL removed the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Dec 20, 2024

MacQSL added 3 commits December 20, 2024 09:41

fix: created component for options menu to prevent multiple menus ope…

f4ea8f3

…ning onClick

fix: updated openapi values type

8e631bd

fix: tests

a9bca4b

NickPhura reviewed Dec 20, 2024

View reviewed changes

api/src/services/import-services/marking/import-markings-service.ts Outdated Show resolved Hide resolved

NickPhura reviewed Dec 20, 2024

View reviewed changes

api/src/services/import-services/marking/marking-header-configs.ts Outdated Show resolved Hide resolved

NickPhura reviewed Dec 20, 2024

View reviewed changes

api/src/utils/csv-utils/csv-config-utils.ts Outdated Show resolved Hide resolved

MacQSL and others added 10 commits December 20, 2024 11:35

fix: pr comments

296ed60

Update getWorksheetRowObjects.

695ff2d

Minor tweak to csv error datagrid settings.

fix: dropped symbol

8eeb9c5

Merge branch 'SIMSBIOHUB-633-markings' of https://github.com/bcgov/bi…

785a9bd

…ohubbc into SIMSBIOHUB-633-markings

Merge branch 'SIMSBIOHUB-633-markings' of https://github.com/bcgov/bi…

d9f50ed

…ohubbc into SIMSBIOHUB-633-markings

Fix getWorksheetRowObjects

a763c3b

feat: added symbol for worksheet rows + PR nits

aa9d2b6

fix: doc language

71076df

fix: created csv-utils file for types and helper functions

db6c944

fix: removed optional for taxon body location

c138cf2

NickPhura reviewed Dec 20, 2024

View reviewed changes

api/src/services/import-services/marking/marking-header-configs.ts Show resolved Hide resolved

NickPhura approved these changes Dec 20, 2024

View reviewed changes

MacQSL merged commit c7146cb into dev Dec 20, 2024
23 of 24 checks passed

MacQSL deleted the SIMSBIOHUB-633-markings branch December 20, 2024 22:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SIMSBIOHUB-656: Import CSV Markings #1451

SIMSBIOHUB-656: Import CSV Markings #1451

MacQSL commented Dec 11, 2024 •

edited

Loading

sonarqubecloud bot commented Dec 20, 2024

NickPhura left a comment

SIMSBIOHUB-656: Import CSV Markings #1451

SIMSBIOHUB-656: Import CSV Markings #1451

Conversation

MacQSL commented Dec 11, 2024 • edited Loading

Links to Jira Tickets

Description of Changes

Testing Notes

sonarqubecloud bot commented Dec 20, 2024

Quality Gate failed

NickPhura left a comment

Choose a reason for hiding this comment

MacQSL commented Dec 11, 2024 •

edited

Loading