SIMSBIOHUB-659: Add Pagination to System Alerts on Admin Page #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Openshift URLs for the PR Deployment: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1459 +/- ##
==========================================
- Coverage 46.08% 46.07% -0.02%
==========================================
Files 910 911 +1
Lines 23752 23792 +40
Branches 3500 3507 +7
==========================================
+ Hits 10947 10963 +16
- Misses 12189 12211 +22
- Partials 616 618 +2 ☔ View full report in Codecov by Sentry. |
|
nit: the alerts table allows you to sort on the preview column and the status column, but I don't think either of those are setup to sort. Might be worth adding |
Fixed |
|
Openshift URLs for the PR Deployment: |
NickPhura
reviewed
Jan 14, 2025
NickPhura
reviewed
Jan 14, 2025
NickPhura
reviewed
Jan 14, 2025
NickPhura
reviewed
Jan 14, 2025
|
Looks great, just had 1 last comment above the database-model type. |
|
NickPhura
pushed a commit
that referenced
this pull request
Jan 17, 2025
wip wip: create location and date sections on form wip: style subcount form wip: adding measurements to subcounts add dual autocomplete subcount form subcount table on create observation page fix measurement search show measurement options in subcount table on create observation page wip: formik validation add subcount sign placeholder to create request wip: environments incorrectly formatted in handlesubmit fix incorrect key fix environments on create observations page fix measurement interfaces SIMSBIOHUB-659: Add Pagination to System Alerts on Admin Page (#1459) Add Pagination to System Alerts on Admin Page --------- Co-authored-by: Nick Phura <[email protected]> Update CSV Error Import Dialog Styling (#1456) - update csv import error dialog - replace failure snackbar & add frontend pagination to csv import errors BugFix: Fix Type for Capture Attachments (#1460) - modifying critter index file --------- Co-authored-by: Macgregor Aubertin-Young <[email protected]> Co-authored-by: Macgregor Aubertin-Young <[email protected]> BugFix: Method Attributes SQL (#1462) - fix sql Added DualAutocompleteUnitField.tsx to help reduce the size of the DualAutocompleteField.tsx. Renamed some of the dual autocomplete field props, just to make them more consistent/predictable. Fixed missing props in create/edit technique vantages (missing category data type prop). Add formik snackbar error component to observation form. Addressed a few react missing dependency warnings. Update missed jsdoc comments. Update missed jsdoc comments 2. WIP: Add create observation sampling fields. Working sampling fields. Enhancements to sampling fields
NickPhura
pushed a commit
that referenced
this pull request
Jan 21, 2025
wip wip: create location and date sections on form wip: style subcount form wip: adding measurements to subcounts add dual autocomplete subcount form subcount table on create observation page fix measurement search show measurement options in subcount table on create observation page wip: formik validation add subcount sign placeholder to create request wip: environments incorrectly formatted in handlesubmit fix incorrect key fix environments on create observations page fix measurement interfaces SIMSBIOHUB-659: Add Pagination to System Alerts on Admin Page (#1459) Add Pagination to System Alerts on Admin Page --------- Co-authored-by: Nick Phura <[email protected]> Update CSV Error Import Dialog Styling (#1456) - update csv import error dialog - replace failure snackbar & add frontend pagination to csv import errors BugFix: Fix Type for Capture Attachments (#1460) - modifying critter index file --------- Co-authored-by: Macgregor Aubertin-Young <[email protected]> Co-authored-by: Macgregor Aubertin-Young <[email protected]> BugFix: Method Attributes SQL (#1462) - fix sql Added DualAutocompleteUnitField.tsx to help reduce the size of the DualAutocompleteField.tsx. Renamed some of the dual autocomplete field props, just to make them more consistent/predictable. Fixed missing props in create/edit technique vantages (missing category data type prop). Add formik snackbar error component to observation form. Addressed a few react missing dependency warnings. Update missed jsdoc comments. Update missed jsdoc comments 2. WIP: Add create observation sampling fields. Working sampling fields. Enhancements to sampling fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
Description of Changes