Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TECHDEBT: XLSX Date / Time #1466

Merged
merged 16 commits into from
Jan 21, 2025
Merged

TECHDEBT: XLSX Date / Time #1466

merged 16 commits into from
Jan 21, 2025

Conversation

MacQSL
Copy link
Collaborator

@MacQSL MacQSL commented Jan 17, 2025

Description of Changes

  • Fixes issue with incorrect xlsx date parsing
  • Added tests for utility functions and worksheet related functions
  • Dropped a large set of deprecated files and removed unused functions

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.58%. Comparing base (7344aa4) to head (b248bc9).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
api/src/utils/xlsx-utils/cell-utils.ts 94.11% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1466      +/-   ##
==========================================
- Coverage   46.07%   45.58%   -0.49%     
==========================================
  Files         910      902       -8     
  Lines       23796    23247     -549     
  Branches     3512     3399     -113     
==========================================
- Hits        10963    10597     -366     
+ Misses      12215    12075     -140     
+ Partials      618      575      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MacQSL MacQSL added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Jan 17, 2025
@MacQSL MacQSL requested a review from NickPhura January 20, 2025 16:47
@MacQSL MacQSL added Ready For Review PR is ready for review and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Jan 20, 2025
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@MacQSL MacQSL merged commit 2e53ed5 into dev Jan 21, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants