TechDebt: Replace Deprecated DeploymentConfig With Deployment. #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Openshift URLs for the PR Deployment: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1468 +/- ##
==========================================
+ Coverage 45.92% 46.07% +0.15%
==========================================
Files 907 909 +2
Lines 23537 23597 +60
Branches 3492 3504 +12
==========================================
+ Hits 10809 10872 +63
- Misses 12136 12138 +2
+ Partials 592 587 -5 ☔ View full report in Codecov by Sentry. |
NickPhura
force-pushed
the
np_devops_update
branch
from
38160d5 to
f616821
Compare
Drop triggers section.
NickPhura
force-pushed
the
np_devops_update
branch
from
1607c45 to
c391687
Compare
NickPhura
changed the title
… postgres upgrade.
…into np_devops_update
MacQSL
reviewed
Jan 23, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
n/a
Description of Changes
DeploymentConfigis now deprecated in OpenShift. They should still function for now, but are no longer receiving updates, etc.Deployment changes
DeploymentConfigto useDeploymenttriggerssection, as this does not exist inDeploymentRollingUpdatewhich is the only oneDeploymentsupports, with fewer configurable settings.imageproperty, which was previously auto-populated by theDeploymentConfigbased on thetriggerssection (I believe).Deploymentspecifically, underselectoryou have to includematchLabelsOther changes
Testing Notes
OpenShift pipeline works the same as it did before.
The deployments worked in this PR. I also tried making an app change and adding a new migration, just to ensure that they re-deployed correctly, and they did (I reverted those changes afterwards).