Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom yup methods #151

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Add support for custom yup methods #151

merged 2 commits into from
Mar 22, 2021

Conversation

NickPhura
Copy link
Collaborator

@NickPhura NickPhura commented Mar 22, 2021

BHBC-620
Summary Endpoint and code refactoring to support Project editing
Type Story Story
Status In Progress
Points N/A
Labels API

Overview

This PR contains the following changes

Add better support for custom yup methods.

This PR contains the following types of changes

  • New feature (change which adds functionality)
  • Enhancement (improvements to existing functionality)
  • Bug fix (change which fixes an issue)
  • Misc cleanup / Refactoring / Documentation
  • Version change

Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

General

  • I have performed a self-review of my own code

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Screenshots

Please add any relevant UI screenshots, if applicable.

@github-actions
Copy link

Let's make that PR title a 💯 shall we? 💪

Your PR title and story title look slightly different. Just checking in to know if it was intentional!

Story Title Endpoint and code refactoring to support Project editing
PR Title BHBC-620: Add support for custom yup methods

Check out this guide to learn more about PR best-practices.

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #151 (ca0d7e3) into dev (f069c1e) will increase coverage by 0.00%.
The diff coverage is 43.75%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #151   +/-   ##
=======================================
  Coverage   44.52%   44.53%           
=======================================
  Files         102      103    +1     
  Lines        2010     2012    +2     
  Branches      456      459    +3     
=======================================
+ Hits          895      896    +1     
- Misses       1040     1041    +1     
  Partials       75       75           
Impacted Files Coverage Δ
...res/projects/components/ProjectCoordinatorForm.tsx 100.00% <ø> (ø)
...eatures/projects/components/ProjectDetailsForm.tsx 77.77% <ø> (ø)
...eatures/projects/components/ProjectFundingForm.tsx 48.38% <ø> (ø)
...res/projects/components/ProjectFundingItemForm.tsx 40.74% <ø> (ø)
...c/features/projects/components/ProjectIUCNForm.tsx 64.28% <ø> (ø)
...atures/projects/components/ProjectLocationForm.tsx 92.30% <ø> (ø)
...ures/projects/components/ProjectObjectivesForm.tsx 75.00% <ø> (ø)
...features/projects/components/ProjectPermitForm.tsx 81.25% <ø> (ø)
...eatures/projects/components/ProjectSpeciesForm.tsx 100.00% <ø> (ø)
app/src/types/yup.d.ts 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f069c1e...ca0d7e3. Read the comment docs.

@NickPhura NickPhura marked this pull request as ready for review March 22, 2021 19:16
- includes support for custom type definitions
@NickPhura NickPhura changed the title BHBC-620: Add support for custom yup methods Add support for custom yup methods Mar 22, 2021
Copy link
Contributor

@anissa-agahchen anissa-agahchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@anissa-agahchen anissa-agahchen merged commit de6d04f into dev Mar 22, 2021
@anissa-agahchen anissa-agahchen deleted the BHBC-620_2 branch March 22, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants