-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom yup methods #151
Conversation
Let's make that PR title a 💯 shall we? 💪 Your PR title and story title look slightly different. Just checking in to know if it was intentional!
Check out this guide to learn more about PR best-practices. |
Codecov Report
@@ Coverage Diff @@
## dev #151 +/- ##
=======================================
Coverage 44.52% 44.53%
=======================================
Files 102 103 +1
Lines 2010 2012 +2
Branches 456 459 +3
=======================================
+ Hits 895 896 +1
- Misses 1040 1041 +1
Partials 75 75
Continue to review full report at Codecov.
|
- includes support for custom type definitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Kudos, SonarCloud Quality Gate passed!
|
BHBC-620
Overview
This PR contains the following changes
Add better support for custom yup methods.
This PR contains the following types of changes
Checklist
A list of items that are good to consider when making any changes.
Note: this list is not exhaustive, and not all items are always applicable.
General
Code
Style
Documentation
Tests
Linting/Formatting
See the
lint
commands in package.jsonSee the
format
commands in package.jsonSonarCloud
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Screenshots
Please add any relevant UI screenshots, if applicable.