Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Partnership section to the Project View page #155

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Conversation

sdevalapurkar
Copy link
Contributor

@sdevalapurkar sdevalapurkar commented Mar 22, 2021

BHBC-942
Summary Implement the Partnership section to the Project View page
Type Story Story
Status In Progress
Points N/A
Labels -

Overview

This PR contains the following changes

  • Implement the Partnership section to the Project View page

This PR contains the following types of changes

  • New feature (change which adds functionality)
  • Enhancement (improvements to existing functionality)

How Has This Been Tested?

  • Locally

Screenshots

sss

@github-actions
Copy link

💔 The detected issue is not in one of the allowed statuses 💔

Detected Status Peer Review
Allowed Statuses In Progress ✔️

Please ensure your jira story is in one of the allowed statuses

@github-actions
Copy link

This PR is too huge for one to review 💔

Additions 783 🙅‍♀️
Expected ⬇️ 500

Consider breaking it down into multiple small PRs.

Check out this guide to learn more about PR best-practices.

@github-actions
Copy link

I'm a bot and I 👍 this PR title. 🤖

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #155 (2453d28) into dev (e44f050) will increase coverage by 0.53%.
The diff coverage is 82.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #155      +/-   ##
==========================================
+ Coverage   44.80%   45.34%   +0.53%     
==========================================
  Files         104      105       +1     
  Lines        2022     2051      +29     
  Branches      460      467       +7     
==========================================
+ Hits          906      930      +24     
- Misses       1041     1044       +3     
- Partials       75       77       +2     
Impacted Files Coverage Δ
api/src/paths/project/{projectId}.ts 0.00% <0.00%> (ø)
app/src/features/projects/view/ProjectDetails.tsx 100.00% <ø> (ø)
app/src/test-helpers/projectWithDetailsData.ts 100.00% <ø> (ø)
api/src/models/project.ts 54.74% <71.42%> (+0.89%) ⬆️
api/src/queries/project-queries.ts 79.19% <100.00%> (+1.83%) ⬆️
...features/projects/view/components/Partnerships.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e44f050...2453d28. Read the comment docs.

@NickPhura NickPhura merged commit 20427c2 into dev Mar 23, 2021
@NickPhura NickPhura deleted the BHBC-942 branch March 23, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants