Edit Dialog #158

anissa-agahchen · 2021-03-23T18:51:39Z

Overview

Links to jira tickets

{Include links to all of the applicable Jira tickets}

This PR contains the following changes

{List all the relevant changes. If there are many changes across many Jira tickets, organize the changes by Jira ticket}

This PR contains the following types of changes

New feature (change which adds functionality)
Enhancement (improvements to existing functionality)
Bug fix (change which fixes an issue)
Misc cleanup / Refactoring / Documentation
Version change

Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

General

I have performed a self-review of my own code

Code

New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
I have avoided duplicating code when possible, moving re-usable pieces into functions
I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
My code changes account for null/undefined values and handle errors appropriately
My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

My code follows the established style conventions
My code uses native material-ui components/icons/conventions when possible

Documentation

I have commented my code sufficiently, such that an unfamiliar developer could understand my code
I have added/updated README's and related documentation, as needed

Tests

I have added/updated unit tests for any code I've added/updated
I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

I have run the linter and fixed any issues, as needed
See the lint commands in package.json
I have run the formatter and fixed any issues, as needed
See the format commands in package.json

SonarCloud

I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Screenshots

Please add any relevant UI screenshots, if applicable.

github-actions · 2021-03-23T18:51:58Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editdialog

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

codecov · 2021-03-23T18:52:37Z

Codecov Report

Merging #158 (2836fc6) into dev (7fe2180) will increase coverage by 0.10%.
The diff coverage is 58.82%.

@@            Coverage Diff             @@
##              dev     #158      +/-   ##
==========================================
+ Coverage   46.32%   46.42%   +0.10%     
==========================================
  Files         109      110       +1     
  Lines        2053     2070      +17     
  Branches      463      463              
==========================================
+ Hits          951      961      +10     
- Misses       1020     1027       +7     
  Partials       82       82

Impacted Files	Coverage Δ
...res/projects/view/components/ProjectObjectives.tsx	`60.00% <50.00%> (-40.00%)`	⬇️
app/src/components/dialog/EditDialog.tsx	`75.00% <75.00%> (ø)`
app/src/constants/i18n.ts	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe2180...2836fc6. Read the comment docs.

anissa-agahchen · 2021-03-23T18:53:31Z

@sdevalapurkar I addressed your comments from the closed PR, with the exception of the error dialog. I will handle that in the next PR along with the axios call and adding the test for the Edit Dialog.

github-actions · 2021-03-23T18:55:45Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editdialog

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

github-actions · 2021-03-23T19:10:27Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editdialog

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

app/src/components/dialog/EditDialog.tsx

sdevalapurkar · 2021-03-23T19:18:17Z

app/src/components/dialog/EditDialog.test.tsx

+    );
+
+    expect(baseElement).toMatchSnapshot();
+  });


we need to add a test case for when the Yes button is clicked and the onSave is called I think
possibly also for oncancel

app/src/components/dialog/EditDialog.tsx

sdevalapurkar · 2021-03-23T19:20:14Z

app/src/features/projects/view/components/ProjectObjectives.tsx

  } = props;

+  const history = useHistory();
+
+  const openModalEdit = () => {


tests for all these probably need to be added as well, but not a blocker for this PR

github-actions · 2021-03-23T19:30:44Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editdialog

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

sdevalapurkar

lgtm when nick is happy with it, will let him give final approval

github-actions · 2021-03-23T20:05:36Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editdialog

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

github-actions · 2021-03-23T20:08:10Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editdialog

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

sonarqubecloud · 2021-03-23T20:08:43Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

anissa-agahchen added 2 commits March 23, 2021 11:43

edit modal rebased

5c709aa

update snapshots and cleanup

942711f

anissa-agahchen requested a review from sdevalapurkar March 23, 2021 18:51

format

4017801

snapshot

5b6b6fb

sdevalapurkar reviewed Mar 23, 2021

View reviewed changes

cleanup

361d00a

sdevalapurkar previously approved these changes Mar 23, 2021

View reviewed changes

updated type

52965dd

anissa-agahchen dismissed sdevalapurkar’s stale review via 52965dd March 23, 2021 20:05

updated snapshot

2836fc6

sdevalapurkar approved these changes Mar 23, 2021

View reviewed changes

anissa-agahchen merged commit 5cc5efb into dev Mar 23, 2021

anissa-agahchen deleted the editdialog branch March 23, 2021 21:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Edit Dialog #158

Edit Dialog #158

anissa-agahchen commented Mar 23, 2021

github-actions bot commented Mar 23, 2021

codecov bot commented Mar 23, 2021 •

edited

Loading

anissa-agahchen commented Mar 23, 2021 •

edited

Loading

github-actions bot commented Mar 23, 2021

github-actions bot commented Mar 23, 2021

sdevalapurkar Mar 23, 2021

sdevalapurkar Mar 23, 2021

github-actions bot commented Mar 23, 2021

sdevalapurkar left a comment

github-actions bot commented Mar 23, 2021

github-actions bot commented Mar 23, 2021

sonarqubecloud bot commented Mar 23, 2021

Edit Dialog #158

Edit Dialog #158

Conversation

anissa-agahchen commented Mar 23, 2021

Overview

Links to jira tickets

This PR contains the following changes

This PR contains the following types of changes

Checklist

General

Code

Style

Documentation

Tests

Linting/Formatting

SonarCloud

How Has This Been Tested?

Screenshots

github-actions bot commented Mar 23, 2021

codecov bot commented Mar 23, 2021 • edited Loading

Codecov Report

anissa-agahchen commented Mar 23, 2021 • edited Loading

github-actions bot commented Mar 23, 2021

github-actions bot commented Mar 23, 2021

sdevalapurkar Mar 23, 2021

Choose a reason for hiding this comment

sdevalapurkar Mar 23, 2021

Choose a reason for hiding this comment

github-actions bot commented Mar 23, 2021

sdevalapurkar left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 23, 2021

github-actions bot commented Mar 23, 2021

sonarqubecloud bot commented Mar 23, 2021

codecov bot commented Mar 23, 2021 •

edited

Loading

anissa-agahchen commented Mar 23, 2021 •

edited

Loading